Skip to content

fix(nextjs): Only delete clientside bundle source maps with sourcemaps.deleteFilesAfterUpload #13102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jul 30, 2024

Fixes #13099

For currently unknown reasons, deleting the serverside sourcmaps will crash Vercel deployments during build. Working theory is that some manifest references the files, and Vercel tries to upload the files but they're missing when Vercel gets to actually uploading them.

@lforst lforst requested a review from Lms24 July 30, 2024 12:46
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@lforst lforst merged commit ce53667 into develop Jul 30, 2024
100 checks passed
@lforst lforst deleted the lforst-only-del-client-bundle-maps branch July 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourcemaps.deleteSourcemapsAfterUpload breaks Vercel deployment
3 participants