fix(react): Fix React jsx runtime import for esm #12740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12608
Sucrase injects a
"react/jsx-runtime"
import, however, ESM requires this to end in.js
because the react package doesn't have an exports field.With this PR we rewrite the import to
"react/jsx-runtime.js"
for our ESM output.I tried importing running
require.resolve("react/jsx-runtime.js")
with node and it crashed so we likely shouldn't do it for CJS.