Skip to content

feat(feedback): Extra check for iPad in screenshot support #12593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

c298lee
Copy link
Contributor

@c298lee c298lee commented Jun 20, 2024

iPads on iPad OS 13+ will show up as Macintosh in the UserAgent since they show the desktop version of sites. This adds extra checks to distinguish if it's an iPad.

Fixes JAVASCRIPT-2TNR

@c298lee c298lee requested a review from a team as a code owner June 20, 2024 18:51
@c298lee c298lee requested a review from ryan953 June 20, 2024 18:51
@c298lee c298lee enabled auto-merge (squash) June 20, 2024 18:56
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.22 KB (0%)
@sentry/browser (incl. Tracing) 33.31 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.09 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.41 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.14 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.34 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.2 KB (+0.04% 🔺)
@sentry/browser (incl. metrics) 26.5 KB (0%)
@sentry/browser (incl. Feedback) 38.45 KB (+0.09% 🔺)
@sentry/browser (incl. sendFeedback) 26.85 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.45 KB (+0.1% 🔺)
@sentry/react 24.96 KB (0%)
@sentry/react (incl. Tracing) 36.35 KB (0%)
@sentry/vue 26.32 KB (0%)
@sentry/vue (incl. Tracing) 35.16 KB (0%)
@sentry/svelte 22.35 KB (0%)
CDN Bundle 23.41 KB (0%)
CDN Bundle (incl. Tracing) 35.04 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.17 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.37 KB (+0.04% 🔺)
CDN Bundle - uncompressed 68.76 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.61 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.08 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 226.75 KB (+0.04% 🔺)
@sentry/nextjs (client) 36.23 KB (0%)
@sentry/sveltekit (client) 33.95 KB (0%)
@sentry/node 112.99 KB (0%)
@sentry/node - without tracing 90.39 KB (0%)
@sentry/aws-serverless 99.48 KB (0%)

@c298lee c298lee merged commit 44ef79a into develop Jun 20, 2024
108 checks passed
@c298lee c298lee deleted the cl/ipad-screenshot branch June 20, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants