Skip to content

feat: Implement timed events & remove transaction.measurements #11398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 3, 2024

Now, we interpret timed events with special attributes as timed events.

For now, we ignore all other timed events.

@mydea mydea requested review from lforst, Lms24, AbhiPrasad and s1gr1d April 3, 2024 12:37
@mydea mydea self-assigned this Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 76.2 KB (+0.17% 🔺)
@sentry/browser (incl. Tracing, Replay) 67.46 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 71.3 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.03 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing) 32.14 KB (+0.44% 🔺)
@sentry/browser (incl. browserTracingIntegration) 32.14 KB (+0.44% 🔺)
@sentry/browser (incl. feedbackIntegration) 31.28 KB (0%)
@sentry/browser (incl. feedbackModalIntegration) 31.39 KB (0%)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.39 KB (0%)
@sentry/browser (incl. sendFeedback) 27.35 KB (0%)
@sentry/browser 22.52 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 71.21 KB (+0.18% 🔺)
CDN Bundle (incl. Tracing, Replay) 65.92 KB (+0.19% 🔺)
CDN Bundle (incl. Tracing) 32.27 KB (+0.42% 🔺)
CDN Bundle 23.74 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 205.39 KB (+0.18% 🔺)
CDN Bundle (incl. Tracing) - uncompressed 96.1 KB (+0.37% 🔺)
CDN Bundle - uncompressed 70.05 KB (0%)
@sentry/react (incl. Tracing, Replay) 67.46 KB (+0.22% 🔺)
@sentry/react 22.55 KB (0%)

@mydea mydea force-pushed the fn/transaction-measurements branch 2 times, most recently from 6407c4f to 1fd56e0 Compare April 4, 2024 06:48
@mydea mydea force-pushed the fn/transaction-measurements branch from 1fd56e0 to b66c419 Compare April 4, 2024 07:25
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea mydea merged commit 9396528 into develop Apr 4, 2024
@mydea mydea deleted the fn/transaction-measurements branch April 4, 2024 08:54
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
…sentry#11398)

Now, we interpret timed events with special attributes as timed events.

For now, we ignore all other timed events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants