Skip to content

ci(tests): Use docker compose instead of docker-compose #11392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Apr 3, 2024

Seems like GitHub got rid of `docker-compose` on April 2 so we need to use `docker compose` instead now: https://github.com/orgs/community/discussions/116610
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did CI fail before because of this? Regardless, good change

@lforst
Copy link
Contributor Author

lforst commented Apr 3, 2024

Did CI fail before because of this? Regardless, good change

Yes it did! https://github.com/getsentry/sentry-javascript/actions/runs/8536536250/job/23387657644?pr=11389#step:6:49

Seems like they are gradually rolling it out over 4 days so it is actually flakey 😄

@lforst lforst merged commit 98c5275 into develop Apr 3, 2024
@lforst lforst deleted the lforst-docker-compose branch April 3, 2024 11:13
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants