feat(browser): Add lazyLoadIntegration utility
#11339
Conversation
size-limit report 📦
|
| return existing; | ||
| } | ||
|
|
||
| const url = `https://browser.sentry-cdn.com/${SDK_VERSION}/${bundle}.min.js`; |
There was a problem hiding this comment.
Can we make this domain configurable (now or future). It would also help with local dev to point to localhost for example.
There was a problem hiding this comment.
I added a cdnBaseUrl config option for the client!
|
For ESM builds, should we expose a utility that uses If someone uses bundlers it should code split automatically. I fear this will be less effective in certain scenarios because adblockers will block |
mydea
force-pushed
the
fn/lazy-load-integration
branch
from
6aa9ec2 to
dee0033
Compare
Hmm not sure, wouldn't it be better for them to just await import the integration themselves then? If you have a bundler there is no need really to use this if you don't want to...? |
mydea
force-pushed
the
fn/lazy-load-integration
branch
2 times, most recently
from
aac25b7 to
2efd866
Compare
mydea
changed the title
lazyLoadIntegration utilitylazyLoadIntegration utility
There was a problem hiding this comment.
Lets merge this in so we can start testing/running it end to end! Overall it's looking ready to me.
The LazyLoadableIntegrations list is something to maintain going forward, but since the integration and bundle names are different seems like an inherent the cost of doing this kind of thing.
This can be used to lazy load a pluggable integration.
mydea
force-pushed
the
fn/lazy-load-integration
branch
from
f2eb5e4 to
12eecd7
Compare
This can be used to lazy load a pluggable integration.
Usage:
```js
async function getOrLazyLoadFeedback() {
const existing = Sentry.getFeedback(); // check if it has already been installed
if (existing) {
return existing;
}
try {
const feedbackIntegration = await Sentry.lazyLoadIntegration('feedbackIntegration');
client.addIntegration(feedbackIntegration());
} catch(error) {
// this can error, we need to handle this!
}
}
```
Closes getsentry#10905
This can be used to lazy load a pluggable integration.
Usage:
Closes #10905