-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(google-cloud): Add @sentry/google-cloud package #10993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1df4b68
to
c654ce5
Compare
}, | ||
extends: ['../../.eslintrc.js'], | ||
rules: { | ||
'@sentry-internal/sdk/no-optional-chaining': 'off', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: I think this is by now disabled by default, so we don't need to overwrite this anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Just realized we never tracked the serverless package in the release registry 😅
Let's make sure we add this package (and the AWS one) to the release registry once we're stable with v8. Before adding it to the registry though, we need to ship a stable v8 version first (pre-releases aren't tracked in the registry).
great point!! added it to the TODO |
677ddd4
to
e0d5af2
Compare
ref #10976
in the first step to our serverless changes, introduce a
@sentry/google-cloud
package that contains all google cloud functions related functionality.No migration guide yet, will write that after I merge this in and open a PR for the aws changes.