Skip to content

feat(google-cloud): Add @sentry/google-cloud package #10993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

AbhiPrasad
Copy link
Member

ref #10976

in the first step to our serverless changes, introduce a @sentry/google-cloud package that contains all google cloud functions related functionality.

No migration guide yet, will write that after I merge this in and open a PR for the aws changes.

@AbhiPrasad AbhiPrasad requested review from a team, mydea and Lms24 and removed request for a team March 8, 2024 16:36
@AbhiPrasad AbhiPrasad force-pushed the abhi-google-cloud-package branch from 1df4b68 to c654ce5 Compare March 8, 2024 17:57
},
extends: ['../../.eslintrc.js'],
rules: {
'@sentry-internal/sdk/no-optional-chaining': 'off',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: I think this is by now disabled by default, so we don't need to overwrite this anymore.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Just realized we never tracked the serverless package in the release registry 😅

Let's make sure we add this package (and the AWS one) to the release registry once we're stable with v8. Before adding it to the registry though, we need to ship a stable v8 version first (pre-releases aren't tracked in the registry).

@AbhiPrasad
Copy link
Member Author

Let's make sure we add this package (and the AWS one) to the release registry once we're stable with v8. Before adding it to the registry though, we need to ship a stable v8 version first (pre-releases aren't tracked in the registry).

great point!! added it to the TODO

@AbhiPrasad AbhiPrasad force-pushed the abhi-google-cloud-package branch from 677ddd4 to e0d5af2 Compare March 11, 2024 18:51
@AbhiPrasad AbhiPrasad merged commit 249a313 into develop Mar 11, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-google-cloud-package branch March 11, 2024 21:26
@AbhiPrasad AbhiPrasad self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants