-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Bump Webpack Plugin to version 2 and rework config options #10978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
// TODO: Add this option | ||
// deleteSourcemapsAfterUpload?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it's probably also fine to just use the already available filesToDeleteAfterUpload
option instead but feel free to implement this, too. I believe we had this option before in NextJS, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will probably think a bit harder about what to do here when I get to it. The reason why such a utility option may be nice is because the dist folder of Next.js projects is configurable.
}); | ||
}); | ||
|
||
it('returns the right `assets` and `ignore` values when run on the client', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to clarify, do you mean with "when run on the client" that client bundles are generated? Just wanna avoid confusion here 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I'll update the wording!
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
Bumps the dependency of
@sentry/webpack
plugin to version 2. Because this is a major bump and we exported the plugin's options directly, this is a breaking change in the SDK.We use this opportunity to merge the webpack plugin options argument with the SDK build-time options argument in
withSentryConfig()
(making things easier to set up) and additionally we overthink all the options we expose - intentionally not completely re-exporting the entire options of the plugin again.