feat(nextjs): Bump Webpack Plugin to version 2 and rework config options #10978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
3 tasks
Lms24
approved these changes
Mar 11, 2024
Comment on lines
+150
to
+151
| // TODO: Add this option | ||
| // deleteSourcemapsAfterUpload?: boolean; |
There was a problem hiding this comment.
IMHO it's probably also fine to just use the already available filesToDeleteAfterUpload option instead but feel free to implement this, too. I believe we had this option before in NextJS, right?
There was a problem hiding this comment.
I will probably think a bit harder about what to do here when I get to it. The reason why such a utility option may be nice is because the dist folder of Next.js projects is configurable.
| }); | ||
| }); | ||
|
|
||
| it('returns the right `assets` and `ignore` values when run on the client', () => { |
There was a problem hiding this comment.
just to clarify, do you mean with "when run on the client" that client bundles are generated? Just wanna avoid confusion here 😅
There was a problem hiding this comment.
Correct, I'll update the wording!
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the dependency of
@sentry/webpackplugin to version 2. Because this is a major bump and we exported the plugin's options directly, this is a breaking change in the SDK.We use this opportunity to merge the webpack plugin options argument with the SDK build-time options argument in
withSentryConfig()(making things easier to set up) and additionally we overthink all the options we expose - intentionally not completely re-exporting the entire options of the plugin again.