Skip to content

ref: Refactor span status handling to be OTEL compatible #10871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 29, 2024

This aligns the schema for span.setStatus() with the OTEL span schema.

Since we still rely, internally, that the status is a string, we now handle this by using the message on the status, if set, to send this. We can internally look at changing this, but this should be OK for now.

@mydea mydea requested review from AbhiPrasad and s1gr1d February 29, 2024 16:08
@mydea mydea self-assigned this Feb 29, 2024
Copy link
Contributor

github-actions bot commented Feb 29, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.26 KB (-0.19% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.49 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.42 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.04 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.72 KB (-0.38% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.72 KB (-0.38% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.06 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.06 KB (0%)
@sentry/browser - Webpack (gzipped) 22.3 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.67 KB (-0.21% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.34 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.16 KB (-0.39% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.8 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.96 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.7 KB (-0.12% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.1 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.21 KB (-0.39% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.77 KB (-0.17% 🔽)
@sentry/react - Webpack (gzipped) 22.33 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.23 KB (-0.15% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 49.58 KB (-0.24% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.09 KB (0%)

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mydea mydea force-pushed the fn/span-setStatus branch from f2f2b92 to 0b0f952 Compare March 1, 2024 11:32
@mydea mydea requested a review from lforst March 4, 2024 08:42
@mydea mydea merged commit 68fa29e into develop Mar 4, 2024
@mydea mydea deleted the fn/span-setStatus branch March 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants