feat(performance): Adds exclusive time and measurements to spans #10704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This will be used in standalone INP spans |
edwardgou-sentry
force-pushed
the
egou/v7/feat/add-exclusive-time-and-measurements-to-spans
branch
from
809e0c7 to
f7d70a0
Compare
AbhiPrasad
reviewed
Feb 20, 2024
…/v7/feat/add-exclusive-time-and-measurements-to-spans
AbhiPrasad
reviewed
Feb 23, 2024
packages/types/src/span.ts
Outdated
| @@ -21,13 +22,15 @@ export type SpanAttributeValue = | |||
| | boolean | |||
| | Array<null | undefined | string> | |||
| | Array<null | undefined | number> | |||
| | Array<null | undefined | boolean>; | |||
| | Array<null | undefined | boolean> | |||
| | Measurements; | |||
There was a problem hiding this comment.
This breaks OTEL compatibility unfortunately. We'll just add them to span data directly for now, but we need a bigger strategy afterwards.
There was a problem hiding this comment.
Yeah I think we'll probably have to flatten measurements into the attributes, or something similar in the future
This reverts commit 2b495f1.
…/v7/feat/add-exclusive-time-and-measurements-to-spans
AbhiPrasad
approved these changes
Feb 29, 2024
edwardgou-sentry
deleted the
egou/v7/feat/add-exclusive-time-and-measurements-to-spans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds exclusive_time and measurements as fields to the Span class. Drops measurements from Transactions since it is now inherited from spans.
Note: this changes
SpanAttributestype and allows Measurements as a value