Skip to content

feat(v8/node): Remove LocalVariables class integration #10558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,7 @@ Sentry.init({
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
// Adjust this value in production, or use tracesSampler for greater control
tracesSampleRate: 1.0,
// ...
// Note: if you want to override the automatic release value, do not set a
// `release` value here - use the environment variable `SENTRY_RELEASE`, so
// that it will also get attached to your source maps

integrations: [new Sentry.Integrations.LocalVariables()],
integrations: [Sentry.localVariablesIntegration()],
});

Sentry.addEventProcessor(event => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Sentry.init({
includeLocalVariables: true,
transport: loggingTransport,
// Stop the rate limiting from kicking in
integrations: [new Sentry.Integrations.LocalVariables({ maxExceptionsPerSecond: 10000000 })],
integrations: [Sentry.localVariablesIntegration({ maxExceptionsPerSecond: 10000000 })],
});

class Some {
Expand Down
1 change: 0 additions & 1 deletion packages/bun/src/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export const defaultIntegrations = [
// new NodeIntegrations.OnUnhandledRejection(),
// Event Info
contextLinesIntegration(),
// new NodeIntegrations.LocalVariables(), # does't work with Bun
nodeContextIntegration(),
modulesIntegration(),
// Bun Specific
Expand Down
12 changes: 1 addition & 11 deletions packages/node-experimental/src/integrations/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,10 @@ const {
ContextLines,
Context,
RequestData,
LocalVariables,
// eslint-disable-next-line deprecation/deprecation
} = NodeIntegrations;

export {
Console,
OnUncaughtException,
OnUnhandledRejection,
Modules,
ContextLines,
Context,
RequestData,
LocalVariables,
};
export { Console, OnUncaughtException, OnUnhandledRejection, Modules, ContextLines, Context, RequestData };

/* eslint-disable deprecation/deprecation */
export { Express } from './express';
Expand Down
1 change: 0 additions & 1 deletion packages/node/src/integrations/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export { Modules } from './modules';
export { ContextLines } from './contextlines';
export { Context } from './context';
export { RequestData } from '@sentry/core';
export { LocalVariables } from './local-variables';
export { Undici } from './undici';
export { Spotlight } from './spotlight';
export { Anr } from './anr';
Expand Down
12 changes: 1 addition & 11 deletions packages/node/src/integrations/local-variables/index.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,3 @@
import { LocalVariablesSync, localVariablesSyncIntegration } from './local-variables-sync';

/**
* Adds local variables to exception frames.
*
* @deprecated Use `localVariablesIntegration()` instead.
*/
// eslint-disable-next-line deprecation/deprecation
export const LocalVariables = LocalVariablesSync;
// eslint-disable-next-line deprecation/deprecation
export type LocalVariables = LocalVariablesSync;
import { localVariablesSyncIntegration } from './local-variables-sync';

export const localVariablesIntegration = localVariablesSyncIntegration;