Risk of wrongly spreading a string in captureRemixErrorBoundaryError

[hanayashiki]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/remix

SDK Version

7.74.0

Framework Version

React 18.2.0

Link to Sentry event

https://monoid.sentry.io/issues/4545141368/events/1285f64c9bfb4e41af32e5447693ef81/?project=4506041272500224&query=is%3Aunresolved&referrer=next-event&statsPeriod=14d&stream_index=0

SDK Setup

No response

Steps to Reproduce

1. Capture the error returned by useRouteError

export function ErrorBoundary() {
  const error = useRouteError();

  captureRemixErrorBoundaryError(error);
}

2. Trigger a remix 404 error:

No routes matched location "/daw/" 

3. The error tags look like a wrongly spreaded string:

Expected Result

The error message is displayed normally.

Actual Result

The error message is displayed like a spreaded string.

The root cause seems to be here:

sentry-javascript/packages/remix/src/client/errors.tsx

Line 25 in cadeefe

...error.data,

When the event.data is a string, it will be spreaded into eventData as something like { 0: 'a', 1: 'b', 2: 'c' ... }, which scrambles the display of error data on the page.

[Lms24]

Hi @hanayashiki just to confirm, you're using @sentry/remix, correct? Asking because you selected @sentry/astro in the issue template.

[AbhiPrasad]

Yeah seems like this is Remix specific. Backlogging for now, but PRs are welcome to fix!

[Dhoni77]

Hi @AbhiPrasad I would like to work on this issue

[hanayashiki]

Hi @hanayashiki just to confirm, you're using @sentry/remix, correct? Asking because you selected @sentry/astro in the issue template.

My bad, sorry

[AbhiPrasad]

@Dhoni77 please go for it!

[hanayashiki]

@Dhoni77 please go for it!

where did he go

[AbhiPrasad]

Seems like he didn't pick it up - PRs are welcome from anyone else!