-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Risk of wrongly spreading a string in captureRemixErrorBoundaryError #9279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @hanayashiki just to confirm, you're using |
Yeah seems like this is Remix specific. Backlogging for now, but PRs are welcome to fix! |
Hi @AbhiPrasad I would like to work on this issue |
My bad, sorry |
@Dhoni77 please go for it! |
where did he go |
Seems like he didn't pick it up - PRs are welcome from anyone else! |
Uh oh!
There was an error while loading. Please reload this page.
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/remix
SDK Version
7.74.0
Framework Version
React 18.2.0
Link to Sentry event
https://monoid.sentry.io/issues/4545141368/events/1285f64c9bfb4e41af32e5447693ef81/?project=4506041272500224&query=is%3Aunresolved&referrer=next-event&statsPeriod=14d&stream_index=0
SDK Setup
No response
Steps to Reproduce
error
returned byuseRouteError
Expected Result
The error message is displayed normally.
Actual Result
The error message is displayed like a spreaded string.
The root cause seems to be here:
sentry-javascript/packages/remix/src/client/errors.tsx
Line 25 in cadeefe
When the
event.data
is a string, it will be spreaded intoeventData
as something like{ 0: 'a', 1: 'b', 2: 'c' ... }
, which scrambles the display of error data on the page.The text was updated successfully, but these errors were encountered: