SvelteKit redirects thrown in instrumented load functions should not trigger captureException

[ncvc]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using? If you use the CDN bundles, please specify the exact bundle (e.g. bundle.tracing.min.js) in your SDK setup.

@sentry/sveltekit

SDK Version

7.46.0

Framework Version

1.14.0

Link to Sentry event

https://agent-tax.sentry.io/issues/4060190821/events/bb31c59cd19e4408b51221e4a4a1904b/?project=6229544

SDK Setup

No response

Steps to Reproduce

Instrument a Sveltekit load function in a +page.ts file with wrapLoadWithSentry, and throw a redirect.

For instance:

import { wrapLoadWithSentry } from "@sentry/sveltekit";
import { redirect } from "@sveltejs/kit";

import type { PageLoad } from "./$types";

export const load: PageLoad = wrapLoadWithSentry(async () => {
  throw redirect(302, "/some/other/path");
});

Expected Result

redirect errors thrown from load functions should not create a new issue in sentry, since this is just a control flow mechanism in load functions to return a redirect.

It looks like this can be ignored in the same place sentry is ignoring 4xx errors on the server side:

sentry-javascript/packages/sveltekit/src/server/load.ts

Line 22 in 776d9ce

if (isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400) {

And I believe there should be similar logic in the client side as well:

sentry-javascript/packages/sveltekit/src/client/load.ts

Line 9 in 776d9ce

const objectifiedErr = objectify(e);

Actual Result

A new issue is created when a redirect error is thrown in a load function

[Lms24]

Hi @ncvc thanks for reporting and for digging through our code :) You're absolutely right, we missed this. I'll work on this soon.

[abirtley]

The incorrect behaviour seems to be present in @sentry/sveltekit@7.52.1 - after following the setup instructions, with a pretty vanilla SvelteKit application, redirects from within the server hooks handle() function are being reported to Sentry as errors. Or rather, we see the following error since a SvelteKit redirect is not an instance of class Error:

Object.captureException
💀 Unhandled Non-Error exception captured with keys: location, status

A minimal reproduction would be something like this:

// hooks.server.ts
export const handle = async ({ event, resolve }) => {
  // dummy logic to handle users who aren't logged in
  if (event.url.pathname !== '/login') {
    throw redirect(303, '/login');
  }

  const response = await resolve(event);
  return response;
};

[Lms24]

I extracted this to a separate issue as it's not related to load functions