[nextjs] v7.29.0 breaks reading next.config.js resulting into missing runtimeConfig

[vire]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/nextjs

SDK Version

7.29.0

Framework Version

@sentry/nextjs@7.29.0

Link to Sentry event

No response

Steps to Reproduce

1. run yarn add -D @sentry/nextjs
2. have a next.config.js exporting a function

const { withSentryConfig } = require('@sentry/nextjs')
// see https://nextjs.org/docs/api-reference/next.config.js/introduction
module.exports = (phase, { defaultConfig }) => {
  /**
   * @type {import('next').NextConfig}
   */
  const nextConfig = {
    /* config options here */
  }
  return withSentryConfig(defaultConfig)
}

1 .

see warns

warn  - Invalid next.config.js options detected: 
  - The root value must be an object but it was a function.

See more info here: https://nextjs.org/docs/messages/invalid-next-config
warn  - Detected next.config.js, no exported configuration found. https://nextjs.org/docs/messages/empty-configuration
info  - automatically enabled Fast Refresh for 1 custom loader
^C%              

Expected Result

the next.config.js file should be read as without errors

Actual Result

window.NEXT_DATA.runtimeConfig is missing

[lforst]

Please wrap the exported function with withSentryConfig:

const { withSentryConfig } = require('@sentry/nextjs')
// see https://nextjs.org/docs/api-reference/next.config.js/introduction
module.exports = withSentryConfig((phase, { defaultConfig }) => {
  /**
   * @type {import('next').NextConfig}
   */
  return nextConfig = {
    /* config options here */
  }
})

[vire]

@lforst I've tried that out, but @sentry/nextjs@7.17.3 works with my current setup, upgrading to @sentry/nextjs@7.29 broke my production env

[lforst]

@vire If you look at the method signature of withSentryConfig it always either returned an object or a function. You need to consider that. If your setup breaks with the new version, it always was faulty.

[vire]

@lforst Ok what you suggest works,

but with @sentry/nextjs@7.29.0 I'm hitting another issue with the @sentry/replay lib package it contains hardcoded path to ./node_modules which does not work with yarn berry

[webpack.cache.PackFileCacheStrategy/webpack.FileSystemInfo] Resolving 'rrweb/es/rrweb/packages/rrweb/src/entries/all' in /Users/path/to/project/.yarn/virtual/@sentry-replay-virtual-b637ba30d9/0/cache/@sentry-replay-npm-7.29.0-e553e78caf-539e18c128.zip/node_modules/@sentry/replay/cjs for build dependencies doesn't lead to expected result '/Users/path/to/project/.yarn/virtual/@sentry-replay-virtual-b637ba30d9/0/cache/@sentry-replay-npm-7.29.0-e553e78caf-539e18c128.zip/node_modules/@sentry/replay/cjs/node_modules/rrweb/es/rrweb/packages/rrweb/src/entries/all.js', but to 'Error: Can't resolve 'rrweb/es/rrweb/packages/rrweb/src/entries/all' in '/Users/path/to/project/.yarn/virtual/@sentry-replay-virtual-b637ba30d9/0/cache/@sentry-replay-npm-7.29.0-e553e78caf-539e18c128.zip/node_modules/@sentry/replay/cjs'' instead. Resolving dependencies are ignored for this path.

[lforst]

@vire Great!

As for the other issue, we're tracking that here: #6690