-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Removing generic server instrumentation from @sentry/nextjs
#6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It would be great to have a (non-exhaustive) list of things that this would stop from being captured. As of now it is a bit fuzzy to me. Generally, I think this is great, and all for it, but it may be helpful for future reference to know e.g. A, B, and C are not being sent anymore. Do you have a rough idea of what these would be? |
Ok after looking at it again, it doesn't seem like we are not sending any fewer transactions as long as our auto wrapping is turned on, which it is by default. I believe I confused the "unnecessary" transactions with some client spans. I updated the issue description to reflect this. I guess the downside then is that we're not sending any server transactions in case people turn of the auto wrapping with |
Which, I guess one could argue, is what people would expect when setting this option to |
I guess so! As an additional note to give some more insight on in what cases users might have turned |
Uh oh!
There was an error while loading. Please reload this page.
The generic server instrumentation in the Next.js SDK contains a lot of code, complexity, and a spoooky side-effect. All of the performance and error instrumentation is already covered by our wrappers.
Upsides:
isBuild
functionPotential downsides:
We stop sending certain transactions which may trigger some things in the product (alerts, ...)(See discussion in this issue)instrumentServerFunctions: false
they will not send any server-side transactions anymoreThe text was updated successfully, but these errors were encountered: