Skip to content

[Replay] Upstream replay event sending #6480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
Tracked by #6458
mydea opened this issue Dec 9, 2022 · 2 comments
Closed
5 tasks done
Tracked by #6458

[Replay] Upstream replay event sending #6480

mydea opened this issue Dec 9, 2022 · 2 comments
Assignees
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@mydea
Copy link
Member

mydea commented Dec 9, 2022

Currently, replay events are sent from the replay package in a somewhat "custom" way, buy accessing a bunch of private methods on the hub etc.

We should refactor this so that the replay event types are part of the general API, and so that the replay package can use public APIs for everything.

@Lms24
Copy link
Member

Lms24 commented Dec 12, 2022

Once this is implemented, I think we can revert a good part of #6493 (probably not _breadcrumbs though)

Lms24 added a commit that referenced this issue Dec 12, 2022
In Replay, we access some private methods from the core SDK package from the `Client` class. Because we mangle private fields by default, our SDK CDN bundles wouldn't expose these methods and fields anymore in their clear name to external callers, such as our Replay CDN bundle, producing runtime errors because the methods were not found. 

This patch fixes these errors by explicitly excluding the called private methods from mangling so that they can be accessed externally. This is admittedly not a clean solution but it unblocks minified CDN bundle users. In the long run we can revert this PR once we streamlined Replay event sending into the SDK (#6480) (as well as breadcrumbs via hooks?). 

Note: This unfortunately increases bundle size, not just for the Replay CDN bundle, but also for the Browser SDK CDN bundle.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

No branches or pull requests

2 participants