[Replay] Upstream replay event sending #6480
Assignees
Labels
Package: replay
Issues related to the Sentry Replay SDK
Comments
This was referenced Dec 9, 2022
|
Once this is implemented, I think we can revert a good part of #6493 (probably not |
Lms24
added a commit
that referenced
this issue
Dec 12, 2022
In Replay, we access some private methods from the core SDK package from the `Client` class. Because we mangle private fields by default, our SDK CDN bundles wouldn't expose these methods and fields anymore in their clear name to external callers, such as our Replay CDN bundle, producing runtime errors because the methods were not found. This patch fixes these errors by explicitly excluding the called private methods from mangling so that they can be accessed externally. This is admittedly not a clean solution but it unblocks minified CDN bundle users. In the long run we can revert this PR once we streamlined Replay event sending into the SDK (#6480) (as well as breadcrumbs via hooks?). Note: This unfortunately increases bundle size, not just for the Replay CDN bundle, but also for the Browser SDK CDN bundle.
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Currently, replay events are sent from the replay package in a somewhat "custom" way, buy accessing a bunch of private methods on the hub etc.
We should refactor this so that the replay event types are part of the general API, and so that the replay package can use public APIs for everything.
hub._withClient#6494_waitForErrorwithrecordingMode#6489scope.getLastBreadcrumb()#6495prepareEventutil function #6517_updateSessionFromEvent#6510The text was updated successfully, but these errors were encountered: