Skip to content

Handle Multiple incoming baggage headers #5672

Closed
@Lms24

Description

@Lms24

Problem Statement

Right now, we don't handle multiple baggage headers in one request when handling incoming requests. This could happen though. For instance, the Python SDK does not merge Sentry and 3rd party baggage headers but appends a new baggage header to outgoing requests, leading to potentially two baggage headers in the outgoing requests.

At the moment, we either bail out completely and don't parse any baggage content or we might also just ignore the second header (not sure about this; probably depends on the framework)

Solution Brainstorm

  • Let's identify where this could happen.
    • My guess is Node and Express; maybe Serverless?
    • I don't think we have to care about BrowserTracing (multiple baggage tags are unlikely, IMO)
  • Fix it. First idea: Just append the strings before calling the parseBaggageString function. Might be too simple but it could be a way.
  • Happens in Remix: feat(remix): Continue transaction from request headers #5600 (comment)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions