Consolidate request-handling utils #5599
Labels
Package: nextjs
Issues related to the Sentry Nextjs SDK
Package: node
Issues related to the Sentry Node SDK
Package: remix
Issues related to the Sentry Remix SDK
Type: Improvement
Problem Statement
So while I've been reviewing all the nextjs PRs + working on remix, I figured we should probably take some time to consolidate all the utils we have around managing requests and setting domains, perhaps exporting them all from
@sentry/node
so they can be consumed accordingly.We now have a couple of steps we always need to do here, and there's probably a bunch I'm missing
op
:http.server
,name
:${METHOD} ${PARAMETERIZED_NAME}
5xx
as errorsSolution Brainstorm
Ideally the goal is as follows.
We have a common set of utilities that is all called under the hood, so framework instrumentation just calls
wrapRequestHandler(frameworkRequestHandler))
and everything should be done.This way we can also tell folks in docs to just use our utils if they are using a framework we don't support.
This is tech debt - but worthwhile for us to work on since it'll help unblock future Node SDK work (and reduce all the duplication and inconsistency between express handlers, nextjs
withSentry
, nextjs data fetching instrumentation, and remix.The text was updated successfully, but these errors were encountered: