Code missing in stack traces using 6.18.1

[richardsimko]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/node

SDK Version

6.18.1

Framework Version

No response

Link to Sentry event

https://sentry.io/organizations/waroncancer/issues/3078016889/

Steps to Reproduce

1. upgrade to 6.18.1
2. There is no code preview in the stack trace: https://sentry.io/organizations/waroncancer/issues/3078016889/
3. Revert to 6.18.0
4. Now the code preview works: https://sentry.io/organizations/waroncancer/issues/3079542442

Expected Result

Code exists in stack trace

Actual Result

No code in stack trace

[AbhiPrasad]

This might be due to the changes introduced in #4612.

Does the same issue happen in https://github.com/getsentry/sentry-javascript/releases/tag/6.18.2?

cc @timfish

[timfish]

Which version of node and what platform?

[richardsimko]

Let me try to update and see. NodeJS 16 from the node:16 Docker image.

[richardsimko]

@AbhiPrasad Sadly still not working in 6.18.2. Here is an issue created with that version: https://sentry.io/organizations/waroncancer/issues/3083553794

[AbhiPrasad]

Thank you for testing, we are taking a look. Sorry for the regression here!

[richardsimko]

Thanks for the response, let me know if you need anything else from me.

[timfish]

Abologies, I'm guessing my changes have caused this regression.

Looking at the 6.18.2 event, some stack frames have code context added and some don't. Some frames with code context missing have a filename that starts with async . This will obviously mean the file cannot be located.

[timfish]

@richardsimko are you able to catch this error and share the error.stack string?

I think there are actually a few things at play here.

async + anonymous parsing issues

The node stack parsing code is forked from node-stack-trace which hadn't seen any updates in years. Node v12 introduced async stack traces and there appears to be an issue parsing those in combination with anonymous functions and this can be seen even in your event from 6.18.0.

Incorrect in_app detection for frames

I can see frames where in_app should be true but they've ended up false

Some frames are missing code context

Still not sure what's happening here...