[@sentry/tracing] Express custom middleware detection

[xr0master]

Package + Version

@sentry/tracing 5.25.0

Description

The Performance is great at catching request, but does not detect custom middleware at all. I saw in the documentation how to manually add spans, but how to automate the process? How was express.json tagged as middleware/jsonParser?

Here is init

app.use(Sentry.Handlers.requestHandler());
app.use(Sentry.Handlers.tracingHandler());
app.use(express.json({limit: '25mb'}));
app.use(Sentry.Handlers.errorHandler());

This is an example with several custom middleware.

app.post('/api/send,
  UserController.isAuthenticated,
  SendEmailController.send,
  UserController.saveUserInCache,
);

Unfortunately, these middleware are not included in the report.

Thank you.

[kamilogorek]

Here's the code for that https://github.com/getsentry/sentry-javascript/blob/master/packages/tracing/src/integrations/express.ts

[xr0master]

@kamilogorek thank you, I see. Why is the wrapper for use only?
By analogy, I added a wrapper for POST and everything worked just fine.

var originalAppPost = app.post;
app.post = function () {
      // eslint-disable-next-line prefer-rest-params
      return originalAppPost.apply(this, wrapUseArgs(arguments));
};

The graph looks great.

[xr0master]

Before that, the graph looked very sad, it was impossible to identify the problem.

[kamilogorek]

Closed by #2972