Losing first line of stack trace

[superalex]

I'm using chrome and trying to trace an agular error and the first line is:

at new ProjectsController (http://127.0.0.1:9001/js/app.js?v=1413888176794:14710:7)

There are morelines that work correctly but this one (the first) is ignored when submiting the error to sentry.

I've been checking the computeStackTraceFromStackProp function and I see that:

chrome = /^\s*at (?:((?:\[object object\])?\S+(?: \[as \S+\])?) )?\(?((?:file|https?|chrome-extension):.*?):(\d+)(?::(\d+))?\)?\s*$/i
chrome.exec("    at new ProjectsController (http://127.0.0.1:9001/js/app.js?v=1413888176794:14710:7)")

doesn't recognize the spaces, if I remove the "new" word it works properly.

[mattrobenolt]

Interesting. I'll look into this. 

--Matt Robenolt

@mattrobenolt

On Tue, Oct 21, 2014 at 4:09 AM, Alejandro notifications@github.com
wrote:

I'm using chrome and trying to trace an agular error and the first line is:
at new ProjectsController (http://127.0.0.1:9001/js/app.js?v=1413888176794:14710:7)
There are morelines that work correctly but this one (the first) is ignored when submiting the error to sentry.
I've been checking the computeStackTraceFromStackProp function and I see that:
chrome = /^\s_at (?:((?:[object object])?\S+(?: [as \S+])?) )?(?((?:file|https?|chrome-extension):._?):(\d+)(?::(\d+))?)?\s*$/i
chrome.exec(" at new ProjectsController (http://127.0.0.1:9001/js/app.js?v=1413888176794:14710:7)")

doesn't recognize the spaces, if I remove the "new" word it works properly.

Reply to this email directly or view it on GitHub:
#271

[superalex]

Thanks! 👍

[vitalybe]

This seems to be an issue with TraceKit. I've opened an issue and proposed a fix here: occ/TraceKit#66

[mattrobenolt]

@vitalybe We have a version of TraceKit vendorized in that has changed drastically. The mainline is not supported or maintained.

Do you mind submitting the patch here into ours?

[mattrobenolt]

@vitalybe fwiw, here's our vendorized version: https://github.com/getsentry/raven-js/blob/master/vendor/TraceKit/tracekit.js The same patch should apply.

[mattrobenolt]

Hmm, after testing this, our regular expression is definitely different than what is used in the original issue.

> var chrome = /^\s*at (.+?) ?\(?((?:file|https?|chrome-extension):.*?):(\d+)(?::(\d+))?\)?\s*$/i
undefined
> chrome.exec('    at new ProjectsController (http://127.0.0.1:9001/js/app.js?v=1413888176794:14710:7)')
[ '    at new ProjectsController (http://127.0.0.1:9001/js/app.js?v=1413888176794:14710:7)',
  'new ProjectsController',
  'http://127.0.0.1:9001/js/app.js?v=1413888176794',
  '14710',
  '7',
  index: 0,
  input: '    at new ProjectsController (http://127.0.0.1:9001/js/app.js?v=1413888176794:14710:7)' ]

This appears to parse the line correctly.

[mattrobenolt]

Ohh, turns out this is in master to fix some issues with angular which came from #238.

Closing this since that PR seems to have fixed this case as well.