Unable to override only a few options for `replayIntegration`

[joshkel]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/react

SDK Version

7.95.0

Framework Version

React 18.2.0

Link to Sentry event

No response

SDK Setup

initSentry({
  dsn,
  integrations: [
      replayIntegration({
        maskAllText: true,
        blockAllMedia: true,
      }),
  ],
});

Steps to Reproduce

Pass a few options to replayIntegration in a TypeScript file.

Expected Result

Successful compilation - the changelog and migration docs make me think that this should work the same as new Replay({ maskAllText: true, blockAllMedia: true }).

Actual Result

Compilation errors - replayIntegration is declared as needing a nearly complete ReplayPluginOptions object, so it complains if any options are missing.

[jiadesen]

me too

[Shubhdeep12]

Hi @mydea it looks like the issue is here for replay integration -

sentry-javascript/packages/replay/src/integration.ts

Line 33 in 6fe349f

export const replayIntegration = ((options?: InitialReplayPluginOptions) => {

Reason - InitialReplayPluginOptions creates every option required except sessionSampleRate and errorSampleRate
Suggested fix - the type for options should be ReplayConfiguration imported above and used in the constructor for the replay class.

let me know if it is correct. I'll create a PR then.
Thanks

[AbhiPrasad]

@Shubhdeep12 feel free to throw up a PR, I think that is correct

[Shubhdeep12]

ok great, added a PR @AbhiPrasad