fix(tracemetrics): Send boolean for internal replay attribute (#17908)

Author: chargome

packages/core/src/metrics/internal.ts

@@ -172,7 +172,7 @@ export function _INTERNAL_captureMetric(beforeMetric: Metric, options?: Internal
 
   if (replayId && replay?.getRecordingMode() === 'buffer') {
     // We send this so we can identify cases where the replayId is attached but the replay itself might not have been sent to Sentry
-    setMetricAttribute(processedMetricAttributes, 'sentry._internal.replay_is_buffering', replayId);
+    setMetricAttribute(processedMetricAttributes, 'sentry._internal.replay_is_buffering', true);
   }
 
   const metric: Metric = {

packages/core/test/lib/metrics/internal.test.ts

@@ -450,8 +450,8 @@ describe('_INTERNAL_captureMetric', () => {
           type: 'string',
         },
         'sentry._internal.replay_is_buffering': {
-          value: 'buffer-replay-id',
-          type: 'string',
+          value: true,
+          type: 'boolean',
         },
       });
     });
@@ -577,8 +577,8 @@ describe('_INTERNAL_captureMetric', () => {
           type: 'string',
         },
         'sentry._internal.replay_is_buffering': {
-          value: 'buffer-replay-id',
-          type: 'string',
+          value: true,
+          type: 'boolean',
         },
       });
     });
@@ -736,8 +736,8 @@ describe('_INTERNAL_captureMetric', () => {
           type: 'string',
         },
         'sentry._internal.replay_is_buffering': {
-          value: 'buffer-replay-id',
-          type: 'string',
+          value: true,
+          type: 'boolean',
         },
       });
     });