Skip to content

Commit dbae950

Browse files
committed
ref(browser): Move browserTracing into browser pkg
1 parent 3996e3a commit dbae950

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+213
-207
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-browser-spans/test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@ sentryTest('should add browser-related spans to pageload transaction', async ({
1414
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
1515
const browserSpans = eventData.spans?.filter(({ op }) => op === 'browser');
1616

17-
// Spans `connect`, `cache` and `DNS` are not always inside `pageload` transaction.
17+
// Spans `domContentLoadedEvent`, `connect`, `cache` and `DNS` are not
18+
// always inside `pageload` transaction.
1819
expect(browserSpans?.length).toBeGreaterThanOrEqual(4);
1920

20-
['domContentLoadedEvent', 'loadEvent', 'request', 'response'].forEach(eventDesc =>
21+
['loadEvent', 'request', 'response'].forEach(eventDesc =>
2122
expect(browserSpans).toContainEqual(
2223
expect.objectContaining({
2324
description: eventDesc,

packages/browser-utils/.eslintrc.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@ module.exports = {
1111
},
1212
},
1313
{
14-
files: ['src/browser/web-vitals/**'],
14+
files: ['src/metrics/**'],
1515
rules: {
1616
'@typescript-eslint/explicit-function-return-type': 'off',
17+
'@typescript-eslint/no-non-null-assertion': 'off',
1718
},
1819
},
1920
],

packages/browser-utils/src/browser/index.ts

Lines changed: 0 additions & 18 deletions
This file was deleted.

packages/browser-utils/src/index.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
export {
2-
browserTracingIntegration,
3-
startBrowserTracingNavigationSpan,
4-
startBrowserTracingPageLoadSpan,
5-
BROWSER_TRACING_INTEGRATION_ID,
6-
instrumentOutgoingRequests,
7-
defaultRequestInstrumentationOptions,
82
addPerformanceInstrumentationHandler,
93
addClsInstrumentationHandler,
104
addFidInstrumentationHandler,
115
addTtfbInstrumentationHandler,
126
addLcpInstrumentationHandler,
13-
} from './browser';
7+
} from './metrics/instrument';
8+
9+
export {
10+
addPerformanceEntries,
11+
startTrackingInteractions,
12+
startTrackingLongTasks,
13+
startTrackingWebVitals,
14+
} from './metrics/browserMetrics';
1415

1516
export { addClickKeypressInstrumentationHandler } from './instrument/dom';
1617

@@ -20,5 +21,3 @@ export {
2021
addXhrInstrumentationHandler,
2122
SENTRY_XHR_DATA_KEY,
2223
} from './instrument/xhr';
23-
24-
export type { RequestInstrumentationOptions } from './browser';

packages/browser-utils/src/instrument/dom.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type { HandlerDataDom } from '@sentry/types';
22

33
import { addHandler, addNonEnumerableProperty, fill, maybeInstrument, triggerHandlers, uuid4 } from '@sentry/utils';
4-
import { WINDOW } from '../browser/types';
4+
import { WINDOW } from '../metrics/types';
55

66
type SentryWrappedTarget = HTMLElement & { _sentryId?: string };
77

packages/browser-utils/src/instrument/history.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { HandlerDataHistory } from '@sentry/types';
22
import { addHandler, fill, maybeInstrument, supportsHistory, triggerHandlers } from '@sentry/utils';
3-
import { WINDOW } from '../browser/types';
3+
import { WINDOW } from '../metrics/types';
44

55
let lastHref: string | undefined;
66

packages/browser-utils/src/instrument/xhr.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type { HandlerDataXhr, SentryWrappedXMLHttpRequest, WrappedFunction } from '@sentry/types';
22

33
import { addHandler, fill, isString, maybeInstrument, triggerHandlers } from '@sentry/utils';
4-
import { WINDOW } from '../browser/types';
4+
import { WINDOW } from '../metrics/types';
55

66
export const SENTRY_XHR_DATA_KEY = '__sentry_xhr_v3__';
77

packages/browser-utils/src/browser/metrics/index.ts renamed to packages/browser-utils/src/metrics/browserMetrics.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,18 @@ import type { Measurements, Span, SpanAttributes, StartSpanOptions } from '@sent
55
import { browserPerformanceTimeOrigin, getComponentName, htmlTreeAsString, logger, parseUrl } from '@sentry/utils';
66

77
import { spanToJSON } from '@sentry/core';
8-
import { DEBUG_BUILD } from '../../debug-build';
8+
import { DEBUG_BUILD } from '../debug-build';
99
import {
1010
addClsInstrumentationHandler,
1111
addFidInstrumentationHandler,
1212
addLcpInstrumentationHandler,
1313
addPerformanceInstrumentationHandler,
1414
addTtfbInstrumentationHandler,
15-
} from '../instrument';
16-
import { WINDOW } from '../types';
17-
import { getNavigationEntry } from '../web-vitals/lib/getNavigationEntry';
18-
import { getVisibilityWatcher } from '../web-vitals/lib/getVisibilityWatcher';
15+
} from './instrument';
16+
import { WINDOW } from './types';
1917
import { isMeasurementValue, startAndEndSpan } from './utils';
18+
import { getNavigationEntry } from './web-vitals/lib/getNavigationEntry';
19+
import { getVisibilityWatcher } from './web-vitals/lib/getVisibilityWatcher';
2020

2121
interface NavigatorNetworkInformation {
2222
readonly connection?: NetworkInformation;

0 commit comments

Comments
 (0)