even better logs...

Author: mydea

dev-packages/node-overhead-gh-action/lib/getOverheadMeasurements.mjs

@@ -15,9 +15,10 @@ async function getMeasurements(instrumentFile) {
 
   const cmd = `node ${args.join(' ')}`;
 
+  log('--------------------------------');
   log(`Getting measurements for "${cmd}"`);
 
-  const [appProcess, appProcessClosed] = await startAppProcess(cmd);
+  const killAppProcess = await startAppProcess(cmd);
 
   log('Example app listening, running autocannon...');
 
@@ -26,8 +27,9 @@ async function getMeasurements(instrumentFile) {
   } catch (error) {
     log(`Error running autocannon: ${error}`);
   } finally {
-    appProcess.kill('SIGKILL');
-    await appProcessClosed;
+    log('Killing app process...');
+    await killAppProcess();
+    log('App process killed');
   }
 }
 
@@ -38,9 +40,9 @@ async function startAppProcess(cmd) {
 
   // Promise to keep track of the app process being closed
   let resolveAppClose, rejectAppClose;
-  const appClosePromise = new Promise((res, rej) => {
-    resolveAppClose = res;
-    rejectAppClose = rej;
+  const appClosePromise = new Promise((resolve, reject) => {
+    resolveAppClose = resolve;
+    rejectAppClose = reject;
   });
 
   appProcess.on('close', code => {
@@ -66,7 +68,10 @@ async function startAppProcess(cmd) {
     });
   });
 
-  return [appProcess, appClosePromise];
+  return async () => {
+    appProcess.kill('SIGKILL');
+    await appClosePromise;
+  };
 }
 
 async function startAutocannonProcess() {
@@ -88,15 +93,18 @@ async function startAutocannonProcess() {
   return new Promise((resolve, reject) => {
     autocannon.stderr.on('data', data => {
       log(`autocannon stderr: ${data}`);
-      autocannon.kill();
-      reject(data);
+      autocannon.kill('SIGKILL');
     });
 
     autocannon.on('close', code => {
       log(`autocannon closed with code ${code}`);
       log(`Average requests: ${lastJson?.requests.average}`);
 
-      resolve(lastJson?.requests.average);
+      if (code && code !== 0) {
+        reject(new Error(`Autocannon process exited with code ${code}`));
+      } else {
+        resolve(lastJson?.requests.average);
+      }
     });
   });
 }