Skip to content

Commit 8c3c8ec

Browse files
mydeaLms24
andcommitted
Apply suggestions from code review
Co-authored-by: Lukas Stracke <[email protected]>
1 parent 8bf2e06 commit 8c3c8ec

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

packages/core/src/transports/base.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ export function createTransport(
105105
}
106106

107107
// We use this to identifify if the transport is the base transport
108+
// TODO (v8): Remove this again as we'll no longer need it
108109
send.__sentry__baseTransport__ = true;
109110

110111
return {

packages/replay/src/coreHandlers/handleAfterSendEvent.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ type AfterSendEventCallback = (event: Event, sendResponse: TransportMakeRequestR
1212
*/
1313
export function handleAfterSendEvent(replay: ReplayContainer): AfterSendEventCallback {
1414
// Custom transports may still be returning `Promise<void>`, which means we cannot expect the status code to be available there
15+
// TODO (v8): remove this check as it will no longer be necessary
1516
const enforceStatusCode = isBaseTransportSend();
1617

1718
return (event: Event, sendResponse: TransportMakeRequestResponse | void) => {

0 commit comments

Comments
 (0)