Skip to content

Commit 8063b3e

Browse files
committed
Revert "feat: Ignore ResizeObserver and undefined error"
This reverts commit a2b7e3c.
1 parent a2b7e3c commit 8063b3e

File tree

2 files changed

+1
-34
lines changed

2 files changed

+1
-34
lines changed

packages/core/src/integrations/inboundfilters.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { convertIntegrationFnToClass, defineIntegration } from '../integration';
66

77
// "Script error." is hard coded into browsers for errors that it can't read.
88
// this is the result of a script being pulled in from an external domain and CORS.
9-
const DEFAULT_IGNORE_ERRORS = [/^Script error\.?$/, /^Javascript error: Script error\.? on line 0$/, /^ResizeObserver loop completed with undelivered notifications.$/, /^undefined$/];
9+
const DEFAULT_IGNORE_ERRORS = [/^Script error\.?$/, /^Javascript error: Script error\.? on line 0$/];
1010

1111
/** Options for the InboundFilters integration */
1212
export interface InboundFiltersOptions {

packages/core/test/lib/integrations/inboundfilters.test.ts

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -177,18 +177,6 @@ const SENTRY_EVENT: Event = {
177177
},
178178
};
179179

180-
const BOGUS_EVENT: Event = {
181-
message: '',
182-
exception: {
183-
values: [
184-
{
185-
type: 'Error',
186-
value: 'undefined',
187-
},
188-
],
189-
},
190-
};
191-
192180
const SCRIPT_ERROR_EVENT: Event = {
193181
exception: {
194182
values: [
@@ -200,17 +188,6 @@ const SCRIPT_ERROR_EVENT: Event = {
200188
},
201189
};
202190

203-
const RESIZEOBSERVER_EVENT: Event = {
204-
exception: {
205-
values: [
206-
{
207-
type: 'Error',
208-
value: 'ResizeObserver loop completed with undelivered notifications.',
209-
},
210-
],
211-
},
212-
};
213-
214191
const MALFORMED_EVENT: Event = {
215192
exception: {
216193
values: [
@@ -317,16 +294,6 @@ describe('InboundFilters', () => {
317294
expect(eventProcessor(SCRIPT_ERROR_EVENT, {})).toBe(null);
318295
});
319296

320-
it('uses default filters Resize', () => {
321-
const eventProcessor = createInboundFiltersEventProcessor();
322-
expect(eventProcessor(RESIZEOBSERVER_EVENT, {})).toBe(null);
323-
});
324-
325-
it('uses default filters Empty', () => {
326-
const eventProcessor = createInboundFiltersEventProcessor();
327-
expect(eventProcessor(BOGUS_EVENT, {})).toBe(null);
328-
});
329-
330297
it('filters on last exception when multiple present', () => {
331298
const eventProcessor = createInboundFiltersEventProcessor({
332299
ignoreErrors: ['incorrect type given for parameter `chewToy`'],

0 commit comments

Comments
 (0)