PR feedback

Author: mydea

packages/browser/src/profiling/utils.ts

@@ -564,9 +564,8 @@ export function addProfileToGlobalCache(profile_id: string, profile: JSSelfProfi
   PROFILE_MAP.set(profile_id, profile);
 
   if (PROFILE_MAP.size > 30) {
-    const last = PROFILE_MAP.keys().next().value;
-    if (last) {
-      PROFILE_MAP.delete(last);
-    }
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const last = PROFILE_MAP.keys().next().value!;
+    PROFILE_MAP.delete(last);
   }
 }

packages/core/src/utils/lru.ts

@@ -27,10 +27,9 @@ export class LRUMap<K, V> {
   public set(key: K, value: V): void {
     if (this._cache.size >= this._maxSize) {
       // keys() returns an iterator in insertion order so keys().next() gives us the oldest key
-      const nextKey = this._cache.keys().next().value;
-      if (nextKey) {
-        this._cache.delete(nextKey);
-      }
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+      const nextKey = this._cache.keys().next().value!;
+      this._cache.delete(nextKey);
     }
     this._cache.set(key, value);
   }