review suggestions

Author: Lms24

packages/core/src/tracing/span.ts

@@ -133,7 +133,8 @@ export class Span implements SpanInterface {
     // eslint-disable-next-line deprecation/deprecation
     this.instrumenter = spanContext.instrumenter || 'sentry';
 
-    this._attributes = dropUndefinedKeys({
+    this._attributes = {};
+    this.setAttributes({
       [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: spanContext.origin || 'manual',
       [SEMANTIC_ATTRIBUTE_SENTRY_OP]: spanContext.op,
       ...spanContext.attributes,

packages/tracing-internal/src/node/integrations/prisma.ts

@@ -1,4 +1,4 @@
-import { getCurrentHub, startSpan } from '@sentry/core';
+import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, getCurrentHub, startSpan } from '@sentry/core';
 import type { Integration } from '@sentry/types';
 import { addNonEnumerableProperty, logger } from '@sentry/utils';
 
@@ -104,7 +104,9 @@ export class Prisma implements Integration {
           {
             name: model ? `${model} ${action}` : action,
             op: 'db.prisma',
-            origin: 'auto.db.prisma',
+            attributes: {
+              [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.db.prisma',
+            },
             data: { ...clientData, 'db.operation': action },
           },
           () => next(params),

packages/tracing/test/hub.test.ts

@@ -305,8 +305,8 @@ describe('Hub', () => {
         makeMain(hub);
         hub.startTransaction({ name: 'dogpark', parentSampled: true });
 
-        // length 1 because `sentry.origin` is set on span initialization
-        expect(Transaction.prototype.setAttribute).toHaveBeenCalledTimes(1);
+        // length 2 because origin and op are set as attributes on span initialization
+        expect(Transaction.prototype.setAttribute).toHaveBeenCalledTimes(2);
       });
 
       it('should record sampling method and rate when sampling decision comes from traceSampleRate', () => {