Skip to content

remove weird usages of non breaking space <0xa0> #5560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022
Merged

remove weird usages of non breaking space <0xa0> #5560

merged 1 commit into from
Oct 5, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Sep 25, 2022

I assume the random use of non-breaking space 0xa0 is not intentional? they render as &nbsp; and will prevent sensible wrapping of text

image

they show up if u use a better text editor

image

@SimonCropp SimonCropp requested a review from a team September 25, 2022 23:14
@vercel
Copy link

vercel bot commented Sep 25, 2022

@SimonCropp is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@SimonCropp
Copy link
Contributor Author

i would suggest logging an error when 0xa0 is found in mdx. Since it is too difficult to see the intent when most editors render them as normal spaces. and if people really want a non breaking space &nbsp; can be explicitly used

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamping. not sure why native team was tagged for review?

@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 7:17PM (UTC)

@imatwawana
Copy link
Contributor

Thanks very much @SimonCropp!

@SimonCropp SimonCropp deleted the remove-weird-usages-of-non-breaking-space-0xa0- branch October 5, 2022 23:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants