ref(js): Update custom Node Otel setup docs #11697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
mydea
reviewed
Oct 31, 2024
| @@ -111,7 +111,19 @@ If you want to add your own http/node-fetch instrumentation, you have to follow | |||
|
|
|||
| ### Custom HTTP Instrumentation | |||
There was a problem hiding this comment.
Above there is also this sentence:
These are needed to make sure that trace propagation works correctly. Additionally, the HTTP instrumentation is configured to ensure that request isolation is automatically applied for Sentry.
Which we should also adjust (I guess just remove the second sentence?)
There was a problem hiding this comment.
Right, good point. We no longer configure HttpInstrumentation for this but use our own instrumentation. Will remove the sentence
mydea
reviewed
Oct 31, 2024
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
mydea
reviewed
Oct 31, 2024
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Francesco Novy <[email protected]>
mydea
changed the title
mydea
approved these changes
Oct 31, 2024
s1gr1d
approved these changes
Oct 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
This PR updates the Custom Node Otel setup page by:
httpIntegration({spans: false})in 8.35.0IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES