fix(components): Re-add exclude functionality in PageGrid
#11510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
commented
Oct 8, 2024
| @@ -193,6 +192,7 @@ Attributes: | |||
|
|
|||
| - `header` (string) - optional header value to include, rendered as an H2 | |||
| - `nextPages` (boolean) - only render pages which come next based on sidebar ordering | |||
| - `exclude` (string[]) - an array of pages to exclude from the grid. Specify the file name of the page, for example, `"index"` for `index.mdx`. | |||
There was a problem hiding this comment.
hmm looks like this file wasn't formatted previously. I only added this line, rest of the changes in this file is just auto-format.
Bundle ReportChanges will increase total bundle size by 17 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
chargome
approved these changes
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-adds the functionality of the
excludeprop in thePageGridcomponent. I introduced this option in #6404 because I wanted to "feature" certain source maps upload guides for Angular but still display all other guides viaPageGrid. Looks like this funcitonality got lost in one of the major refactorings of our docs repo. So this PR re-adds the filter functionality.(Noticed while reviewing #11494)