Skip to content

[Electron] Offline Integration #5364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LSSangha opened this issue Jul 28, 2022 · 8 comments · Fixed by #5758
Closed

[Electron] Offline Integration #5364

LSSangha opened this issue Jul 28, 2022 · 8 comments · Fixed by #5758
Assignees

Comments

@LSSangha
Copy link
Contributor

Core or SDK?

Platform/SDK

Which part? Which one?

Electron

Description

A customer is requesting we provide an example of how to use the Offline integration for the Electron SDK.

Suggested Solution

Just adding a simple message or so, on how we they can use it for their SDK if needed or not.

@getsentry-release
Copy link
Contributor

Routing to @getsentry/team-web-sdk-frontend for triage. ⏲️

@imatwawana
Copy link
Contributor

hey @LSSangha - when you have a minute, can you please make your github profile public so the issues you create as a team member don't have triage SLOs applied.

@AbhiPrasad
Copy link
Member

The offline integration does not work with the Electron SDK. See a previous issue here: #4215.

We'll probably need to document how to configure the offline transport though, so backlogging this issue for that. cc @timfish whenever you get the time!

@timfish
Copy link
Collaborator

timfish commented Jul 29, 2022

Yep, need to add details for this.

The Electron SDK uses its own offline transport by default. From v4, there's a single configuration option that allows you to queue events rather than send which can be used to disable sending until confirmation of user consent.

@timfish
Copy link
Collaborator

timfish commented Jul 29, 2022

Please assign this issue to me!

@LSSangha
Copy link
Contributor Author

@AbhiPrasad @timfish a customer is asking if there are any other settings they need to turn on for the offline option to work.

@timfish
Copy link
Collaborator

timfish commented Aug 30, 2022

The offline transport has been the default transport since v3 of the Electron SDK and should work without any configuration.

I recently had a PR merged in this repo that removed references to the old JavaScript Offline integration that never worked with Electron.

It sounds like I need to do another PR that:

@jebrubaker
Copy link

jebrubaker commented Aug 30, 2022 via email

lforst pushed a commit that referenced this issue Nov 17, 2022
lforst pushed a commit that referenced this issue Nov 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants