fix: Remove non-allowed file APIs (#3627)

Remove usage of NSFileSystemFreeSize and NSFileSystemSize because Apple
forbids our usage; see
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api?language=objc.

Fixes GH-3590

Author: philipphofmann

CHANGELOG.md

@@ -11,6 +11,9 @@
 
 - Finish TTID span when transaction finishes (#3610)
 - Dont take screenshot and view hierarchy for app hanging (#3620)
+- Remove `free_storage` and `storage_size` from the device context (#3627), because Apple forbids sending
+information retrieved via `NSFileSystemFreeSize` and `NSFileSystemSize` off a device; see
+[Apple docs](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api?language=objc). 
 
 ## 8.20.0
 

Sources/Sentry/SentryClient.m

@@ -628,7 +628,7 @@ - (SentryEvent *_Nullable)prepareEvent:(SentryEvent *)event
         // applicable
         [self removeExtraDeviceContextFromEvent:event];
     } else if (!isCrashEvent) {
-        // Store the current free memory, free storage, battery level and more mutable properties,
+        // Store the current free memory battery level and more mutable properties,
         // at the time of this event, but not for crashes as the current data isn't guaranteed to be
         // the same as when the app crashed.
         [self applyExtraDeviceContextToEvent:event];
@@ -842,7 +842,6 @@ - (void)removeExtraDeviceContextFromEvent:(SentryEvent *)event
                     key:@"device"
                   block:^(NSMutableDictionary *device) {
                       [device removeObjectForKey:SentryDeviceContextFreeMemoryKey];
-                      [device removeObjectForKey:@"free_storage"];
                       [device removeObjectForKey:@"orientation"];
                       [device removeObjectForKey:@"charging"];
                       [device removeObjectForKey:@"battery_level"];

Sources/Sentry/SentryCrashIntegration.m

@@ -266,8 +266,6 @@ + (void)enrichScope:(SentryScope *)scope crashWrapper:(SentryCrashWrapper *)cras
     [deviceData setValue:systemInfo[@"freeMemorySize"] forKey:SentryDeviceContextFreeMemoryKey];
     [deviceData setValue:systemInfo[@"usableMemorySize"] forKey:@"usable_memory"];
     [deviceData setValue:systemInfo[@"memorySize"] forKey:@"memory_size"];
-    [deviceData setValue:systemInfo[@"totalStorageSize"] forKey:@"storage_size"];
-    [deviceData setValue:systemInfo[@"freeStorageSize"] forKey:@"free_storage"];
     [deviceData setValue:systemInfo[@"bootTime"] forKey:@"boot_time"];
 
     NSString *locale = [[NSLocale autoupdatingCurrentLocale] objectForKey:NSLocaleIdentifier];

Sources/Sentry/SentryCrashWrapper.m

@@ -66,11 +66,6 @@ - (bytes)freeMemorySize
     return sentrycrashcm_system_freememory_size();
 }
 
-- (bytes)freeStorageSize
-{
-    return sentrycrashcm_system_freestorage_size();
-}
-
 - (bytes)appMemorySize
 {
     task_vm_info_data_t info;

Sources/Sentry/SentryExtraContextProvider.m

@@ -42,7 +42,6 @@ - (NSDictionary *)getExtraDeviceContext
     NSMutableDictionary *extraDeviceContext = [[NSMutableDictionary alloc] init];
 
     extraDeviceContext[SentryDeviceContextFreeMemoryKey] = @(self.crashWrapper.freeMemorySize);
-    extraDeviceContext[@"free_storage"] = @(self.crashWrapper.freeStorageSize);
     extraDeviceContext[@"processor_count"] = @([self.processInfoWrapper processorCount]);
 
 #if TARGET_OS_IOS && SENTRY_HAS_UIKIT

Sources/Sentry/include/SentryCrashWrapper.h

@@ -33,8 +33,6 @@ SENTRY_NO_INIT
 
 - (bytes)appMemorySize;
 
-- (bytes)freeStorageSize;
-
 @end
 
 NS_ASSUME_NONNULL_END

Sources/SentryCrash/Recording/Monitors/SentryCrashMonitorContext.h

@@ -198,8 +198,6 @@ typedef struct SentryCrash_MonitorContext {
         int parentProcessID;
         const char *deviceAppHash;
         const char *buildType;
-        uint64_t totalStorageSize;
-        uint64_t freeStorageSize;
         uint64_t memorySize;
         uint64_t freeMemorySize;
         uint64_t usableMemorySize;

Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.h

@@ -42,7 +42,6 @@ SentryCrashMonitorAPI *sentrycrashcm_system_getAPI(void);
 bool sentrycrash_isSimulatorBuild(void);
 
 bytes sentrycrashcm_system_freememory_size(void);
-bytes sentrycrashcm_system_freestorage_size(void);
 
 #ifdef __cplusplus
 }

Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.m

@@ -75,8 +75,6 @@
     int parentProcessID;
     const char *deviceAppHash;
     const char *buildType;
-    bytes totalStorageSize;
-    bytes freeStorageSize;
     bytes memorySize;
 } SystemData;
 
@@ -494,30 +492,6 @@
     return "unknown";
 }
 
-static bytes
-getTotalStorageSize(void)
-{
-    NSNumber *storageSize = [[[NSFileManager defaultManager]
-        attributesOfFileSystemForPath:NSHomeDirectory()
-                                error:nil] objectForKey:NSFileSystemSize];
-    return storageSize.unsignedLongLongValue;
-}
-
-static bytes
-getFreeStorageSize(void)
-{
-    NSNumber *storageSize = [[[NSFileManager defaultManager]
-        attributesOfFileSystemForPath:NSHomeDirectory()
-                                error:nil] objectForKey:NSFileSystemFreeSize];
-    return storageSize.unsignedLongLongValue;
-}
-
-bytes
-sentrycrashcm_system_freestorage_size(void)
-{
-    return getFreeStorageSize();
-}
-
 // ============================================================================
 #pragma mark - API -
 // ============================================================================
@@ -598,8 +572,6 @@
         g_systemData.parentProcessID = getppid();
         g_systemData.deviceAppHash = getDeviceAndAppHash();
         g_systemData.buildType = getBuildType();
-        g_systemData.totalStorageSize = getTotalStorageSize();
-        g_systemData.freeStorageSize = getFreeStorageSize();
         g_systemData.memorySize = sentrycrashsysctl_uint64ForName("hw.memsize");
     }
 }
@@ -652,8 +624,6 @@
         COPY_REFERENCE(parentProcessID);
         COPY_REFERENCE(deviceAppHash);
         COPY_REFERENCE(buildType);
-        COPY_REFERENCE(totalStorageSize);
-        COPY_REFERENCE(freeStorageSize);
         COPY_REFERENCE(memorySize);
         eventContext->System.freeMemorySize = freeMemorySize();
         eventContext->System.usableMemorySize = usableMemorySize();

Sources/SentryCrash/Recording/SentryCrash.m

@@ -210,8 +210,6 @@ - (NSDictionary *)systemInfo
     COPY_PRIMITIVE(parentProcessID);
     COPY_STRING(deviceAppHash);
     COPY_STRING(buildType);
-    COPY_PRIMITIVE(totalStorageSize);
-    COPY_PRIMITIVE(freeStorageSize);
     COPY_PRIMITIVE(memorySize);
     COPY_PRIMITIVE(freeMemorySize);
     COPY_PRIMITIVE(usableMemorySize);