Skip to content

feat: Record by default #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2022
Merged

feat: Record by default #281

merged 4 commits into from
Sep 19, 2022

Conversation

kgilpin
Copy link
Contributor

@kgilpin kgilpin commented Sep 13, 2022

Automatically record AppMaps in known environments.

Instructions on how to disable this behavior are already live at appmap.io - https://appmap.io/docs/reference/appmap-ruby.html#enabling-and-disabling-instrumentation

@kgilpin kgilpin force-pushed the feat/record-by-default branch 6 times, most recently from 1ccea7b to 39e48a3 Compare September 19, 2022 17:48
Recording methods are auto-enabled by known environments.
For example, RAILS_ENV and APP_ENV are env vars which indicate
the current environment.

Test case recording is auto-enabled in "test" environments.

Remote and request recording is auto-enabled in "development"
environments.

Recording methods can still be manually enabled or disabled using env
vars. But in most cases, this shouldn't be needed.
Repurpose APPMAP=true a bit, to support a use case like:

gem 'appmap', require: ENV['APPMAP'] == 'true'
@kgilpin kgilpin force-pushed the feat/record-by-default branch from 39e48a3 to 30413cd Compare September 19, 2022 20:43
@kgilpin kgilpin marked this pull request as ready for review September 19, 2022 20:44
Copy link
Contributor

@apotterri apotterri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I miss Ruby.... ;)

@kgilpin kgilpin merged commit 6081f3f into master Sep 19, 2022
@kgilpin kgilpin deleted the feat/record-by-default branch September 19, 2022 22:53
@appland-release
Copy link

🎉 This PR is included in version 0.92.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants