Add Flask 2 support #186
Merged
Add Flask 2 support #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotterri
requested review from
symwell and
dividedmind
and removed request for
symwell
apotterri
commented
Oct 25, 2022
| f"{{{p}}}" if c else p | ||
| for c, _, p in parse_rule(request.url_rule.rule) | ||
| ] | ||
| # Transform request.url to the expected normalized-path form. For example, |
There was a problem hiding this comment.
@dividedmind LMK if this doesn't satisfy your concerns about this change.
There was a problem hiding this comment.
Thanks, looks ok if a bit convoluted :) I'll propose a simpler and perhaps easier to read implementation
symwell
reviewed
Oct 25, 2022
symwell
approved these changes
Oct 25, 2022
dividedmind
reviewed
Oct 25, 2022
| f"{{{p}}}" if c else p | ||
| for c, _, p in parse_rule(request.url_rule.rule) | ||
| ] | ||
| # Transform request.url to the expected normalized-path form. For example, |
There was a problem hiding this comment.
Thanks, looks ok if a bit convoluted :) I'll propose a simpler and perhaps easier to read implementation
dividedmind
approved these changes
Oct 25, 2022
Instead of relying on an internal Flask API to parse a Rule, parse the result of calling repr on it. The format of the string returned by repr is the same for Flask 1 and Flask 2, and has all the information we need.
Remove Flask 1 dependency from pyproject.toml. Instead, add a flask1 factor to tox.ini, and use it for testing Flask 1.
Fix up Flask support so it's compatible with v2. Also fixes initial configuration, so a Flask app will be recorded by default.
Import appmap.django at startup, to make sure our middleware gets injected.
apotterri
force-pushed
the
flask2_20221017
branch
from
c474ff9 to
f15e591
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes getappmap/board/#148.