feat: Add matchIndentation option
#31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In testing the build against actual code, validation seems to fail after the format. I'm verifying my changes, and will update with results. Edit: All seems to be working on real code now |
pgoforth
force-pushed
the
issue-9/matchIndentation
branch
from
6c3dc73 to
7a94ac3
Compare
|
@gajus The other merged commit does not close this PR. Is there something wrong with your automation? Edit: I will test the new version with my existing repo and verify the base indent fixing works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9
I see a few PRs for this issue, and all closed without being merged. I do not know the reasoning:
#11
#25
#28
This PR makes the minimal required changes, includes logic from https://github.com/sindresorhus/indent-string, and adds unit tests, bringing coverage to almost complete (2 branches uncovered, and one is from a typedef).