Put a lock around eccodes usage #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might prevent segfaults
|
@emfdavid , this also fixes an ordering thing that might have been the root cause. The lock may then be superfluous, but probably no hindrance. |
emfdavid
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Hooray! That does it. I was starting to play around with logging exactly where the segfault happens when I saw you email.
Thank you.
Please advise on whether I should pin my build to the merge commit, wait for a 0.1.1 release or make my own patch commit in my fork by cherrypicking your change on
commit b58ad82 (tag: 0.1.0)
Merge: bc3aaff efadcad
Author: Martin Durant [email protected]
Date: Wed Jan 18 20:22:19 2023 -0500
|
I'll merge and release right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might prevent segfaults
#328