Skip to content

Http serialising files #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2020
Merged

Http serialising files #477

merged 2 commits into from
Nov 18, 2020

Conversation

martindurant
Copy link
Member

No description provided.

@martindurant
Copy link
Member Author

Fixes pydata/xarray#4591

@martindurant
Copy link
Member Author

Note: file position will be implicitly reset to start; which maybe OK or maybe not. Really, the open file ought not to be passed around via serialisation.

@rabernat
Copy link
Contributor

Does this have any relationship to #476?

@martindurant
Copy link
Member Author

Yes and no.
When dask handles files for its various IO operations, it passes file system or OpenFile objects around, and things are only opened while the given function is running. The netCDF version seems to keep hold of the open file instead of the URL, and the HTTP variant of this was not serializable until that PR. Still, it should fix your issue.

@martindurant martindurant merged commit e659682 into fsspec:master Nov 18, 2020
@martindurant martindurant deleted the http_ser branch November 18, 2020 19:04
@rabernat rabernat mentioned this pull request Nov 19, 2020
Closed
@TomAugspurger TomAugspurger mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martindurant @rabernat