Skip to content

Integrate sourcelink #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jun 20, 2020
Merged

Integrate sourcelink #950

merged 30 commits into from
Jun 20, 2020

Conversation

baronfel
Copy link
Collaborator

36.0.2

This is a small bugfix release that I'm making primarily to publish a version
of FCS with sourcelink enabled, so that tooling users can make use of that information.

From dotnet/fsharp:079276b4b..37d0ccc:

  • Fixes for do! handling in computation expressions (thanks @baronfel)
  • Add missing versions in FCS' Interactive header (thanks @nightroman)
  • Support Source-translation in match! expressions (thanks @baronfel)
  • Ensure stack traces from uncaught exceptions in CEs are maintained (thanks @NinoFloris)
  • Better handling of inline in witness-passing codepaths (thanks @dsyme)
  • Enable publishing of FCS with sourcelink (thanks @baronfel)
  • Extend nameof to support naming generic parameters (nameof<'t>) and instance members (nameof(Unchecked.defaultof<C>.Property)) (thanks @dsyme)

vzarytovskii and others added 29 commits June 20, 2020 09:25
* I can confirm that dobang is not, in fact, simple

* add test to verify do-bang behavior
* perform sourceExpr translation on match-bang expressions

* add test for match-bang source translations
* Replace throw with EDI throw in CE catch handlers, fixes #8529

* Address feedback, move to EDI.Capture(exn).Throw() for netfx compatibility
* fix pattern match recovery

* add testcase and fixup

* Update TypeChecker.fs
* migrate to netcoreapp3.1

* update comments

* update tool versions
* alternative fix for 9449

* add test case

* fix 9449 properly by assert type equations simultaneously
* Simplify and improve perf of String.length

* Improve performance of String.map

* Revert "Improve performance of String.map"

* Turn String.length into a one-liner, fixes dotnet/fsharp#9469 (comment)
@baronfel baronfel force-pushed the integrate-sourcelink branch from 3af0361 to 31b30b3 Compare June 20, 2020 15:29
@baronfel baronfel marked this pull request as ready for review June 20, 2020 16:54
@baronfel baronfel merged commit c8a935f into fsharp:master Jun 20, 2020
@baronfel baronfel deleted the integrate-sourcelink branch June 20, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants