Skip to content

Commit f7a868a

Browse files
committed
enable more tests on .NET Core
1 parent e904062 commit f7a868a

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

tests/service/EditorTests.fs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -372,11 +372,7 @@ type Test() =
372372
//decls |> List.map (fun d -> d.Head.Symbol.DisplayName) |> printfn "---> decls = %A"
373373
decls |> Seq.exists (fun d -> d.Head.Symbol.DisplayName = "abc") |> shouldEqual true
374374

375-
#if DOTNETCORE
376-
[<Test; Ignore("Currently failing on .NET Core - apparently there are 2 StringBuilder types in the implementation assemblies referenced by mkProjectCommandLineArgsForScript, one found directly and one found via FSharp.Core")>]
377-
#else
378375
[<Test>]
379-
#endif
380376
let ``Printf specifiers for regular and verbatim strings`` () =
381377
let input =
382378
"""let os = System.Text.StringBuilder()

tests/service/ProjectAnalysisTests.fs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4021,9 +4021,6 @@ let ``Test project29 whole project errors`` () =
40214021
wholeProjectResults.Errors.Length |> shouldEqual 0
40224022

40234023
[<Test>]
4024-
#if DOTNETCORE
4025-
[<Ignore("Fails on .NET Core")>]
4026-
#endif
40274024
let ``Test project29 event symbols`` () =
40284025

40294026
let wholeProjectResults = checker.ParseAndCheckProject(Project29.options) |> Async.RunSynchronously
@@ -4144,7 +4141,7 @@ let ``Test project31 whole project errors`` () =
41444141

41454142
[<Test>]
41464143
#if DOTNETCORE
4147-
[<Ignore("Fails on .NET Core")>]
4144+
[<Ignore("Fails on .NET Core - DebuggerTypeProxyAttribute and DebuggerDisplayAttribute note being emitted?")>]
41484145
#endif
41494146
let ``Test project31 C# type attributes`` () =
41504147
if not runningOnMono then
@@ -4193,7 +4190,7 @@ let ``Test project31 C# method attributes`` () =
41934190

41944191
[<Test>]
41954192
#if DOTNETCORE
4196-
[<Ignore("Fails on .NET Core")>]
4193+
[<Ignore("Fails on .NET Core - DebuggerTypeProxyAttribute and DebuggerDisplayAttribute note being emitted?")>]
41974194
#endif
41984195
let ``Test project31 Format C# type attributes`` () =
41994196
if not runningOnMono then

0 commit comments

Comments
 (0)