sync up branch pointers (#902)

sync up branch pointers

Author: baronfel

.gitignore

@@ -4,7 +4,7 @@ artifacts/
 /tests/scripts/current
 .dotnet/
 .packages/
-./tools
+.tools/
 
 # Patches that may have been generated by scripts.
 # (These aren't generally useful to commit directly; if anything, they should be applied.)
@@ -75,11 +75,13 @@ scripts/*.patch
 lib/debug
 lib/release
 lib/proto
-lib/bootstrap/4.0/*.mdb
-lib/bootstrap/4.0/*.xml
-lib/bootstrap/4.0/fsharpc
-lib/bootstrap/4.0/fsharpi
-lib/bootstrap/4.0/policy*
+lib/bootstrap/4.1/*.mdb
+lib/bootstrap/4.1/*.xml
+lib/bootstrap/4.1/fsharpc
+lib/bootstrap/4.1/fsharpi
+lib/bootstrap/4.1/policy*
+obj/
+bin/
 aclocal.m4
 src/*.userprefs
 src/fsharp/FSStrings.resources
@@ -202,7 +204,6 @@ src/fsharp/FSharp.Compiler.Service/pppars.fsi
 *.cto
 *.vstman
 project.lock.json
-
 src/fsharp/FSharp.Compiler.Service/FSComp.fs
 src/fsharp/FSharp.Compiler.Service/FSComp.resx
 src/fsharp/FSharp.Compiler.Service/FSIstrings.fs
@@ -231,4 +232,5 @@ msbuild.binlog
 /fcs/FSharp.Compiler.Service.netstandard/*.fs
 /fcs/FSharp.Compiler.Service.netstandard/*.fsi
 
-.ionide
+.ionide
+.vscode

.nuget/NuGet.exe

@@ -0,0 +1,30 @@
+{
+  "version": "1.0",
+  "components": [
+    "Microsoft.VisualStudio.Component.CoreEditor",
+    "Microsoft.VisualStudio.Workload.CoreEditor",
+    "Microsoft.VisualStudio.Component.NuGet",
+    "Microsoft.Net.Component.4.6.1.TargetingPack",
+    "Microsoft.VisualStudio.Component.Roslyn.Compiler",
+    "Microsoft.VisualStudio.Component.Roslyn.LanguageServices",
+    "Microsoft.VisualStudio.Component.FSharp",
+    "Microsoft.Net.Core.Component.SDK.2.1",
+    "Microsoft.NetCore.ComponentGroup.DevelopmentTools.2.1",
+    "Microsoft.Net.Component.4.7.2.SDK",
+    "Microsoft.Net.Component.4.7.2.TargetingPack",
+    "Microsoft.Net.ComponentGroup.DevelopmentPrerequisites",
+    "Microsoft.Component.MSBuild",
+    "Microsoft.VisualStudio.Component.TextTemplating",
+    "Microsoft.VisualStudio.Component.SQL.CLR",
+    "Microsoft.VisualStudio.Component.ManagedDesktop.Core",
+    "Microsoft.Net.Component.4.6.TargetingPack",
+    "Component.Microsoft.VisualStudio.LiveShare",
+    "Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites",
+    "Microsoft.VisualStudio.Component.Debugger.JustInTime",
+    "Microsoft.VisualStudio.Component.FSharp.Desktop",
+    "Microsoft.VisualStudio.Workload.ManagedDesktop",
+    "Microsoft.VisualStudio.Component.VSSDK",
+    "Microsoft.VisualStudio.ComponentGroup.VisualStudioExtension.Prerequisites",
+    "Microsoft.VisualStudio.Workload.VisualStudioExtension"
+  ]
+}

.nuget/NuGet.targets

@@ -90,7 +90,7 @@ jobs:
 
 - job: Windows
   pool:
-    vmImage: vs2017-win2016
+    vmImage: windows-2019
   timeoutInMinutes: 120
   strategy:
     maxParallel: 4
@@ -128,7 +128,7 @@ jobs:
 
 - job: Windows_FCS
   pool:
-    vmImage: vs2017-win2016
+    vmImage: windows-2019
   timeoutInMinutes: 120
   steps:
   - script: fcs\build.cmd TestAndNuget
@@ -140,3 +140,33 @@ jobs:
       publishLocation: Container
     continueOnError: true
     condition: not(succeeded())
+
+- job: SourceBuild_Linux
+  pool:
+    vmImage: ubuntu-16.04
+  timeoutInMinutes: 90
+  steps:
+  - script: ./eng/cibuild.sh --configuration Release /p:DotNetBuildFromSource=true /p:FSharpSourceBuild=true
+  - task: PublishBuildArtifacts@1
+    displayName: Publish Build Logs
+    inputs:
+      PathtoPublish: '$(Build.SourcesDirectory)/artifacts/log/Release'
+      ArtifactName: 'SourceBuild_Linux build log'
+      publishLocation: Container
+    continueOnError: true
+    condition: not(succeeded())
+
+- job: SourceBuild_Windows
+  pool:
+    vmImage: windows-2019
+  timeoutInMinutes: 90
+  steps:
+  - script: eng\CIBuild.cmd -configuration Release -noSign /p:DotNetBuildFromSource=true /p:FSharpSourceBuild=true
+  - task: PublishBuildArtifacts@1
+    displayName: Publish Build Logs
+    inputs:
+      PathtoPublish: '$(Build.SourcesDirectory)\artifacts\log\Release'
+      ArtifactName: 'SourceBuild_Windows build log'
+      publishLocation: Container
+    continueOnError: true
+    condition: not(succeeded())

.vsconfig

@@ -39,7 +39,6 @@
     <DefineConstants>$(DefineConstants);FX_NO_WINFORMS</DefineConstants>
     <DefineConstants>$(DefineConstants);FX_NO_INDENTED_TEXT_WRITER</DefineConstants>
     <DefineConstants>$(DefineConstants);FX_REDUCED_EXCEPTIONS</DefineConstants>
-    <DefineConstants>$(DefineConstants);FX_REDUCED_CONSOLE</DefineConstants>
     <DefineConstants>$(DefineConstants);FX_RESHAPED_REFEMIT</DefineConstants>
     <DefineConstants>$(DefineConstants);FX_RESHAPED_GLOBALIZATION</DefineConstants>
     <DefineConstants>$(DefineConstants);FX_RESHAPED_REFLECTION</DefineConstants>

.vsts-pr.yaml

@@ -69,6 +69,21 @@
     <UpdateXlfOnBuild Condition="'$(CI)' != '1'">true</UpdateXlfOnBuild>
   </PropertyGroup>
 
+  <!-- source-build workarounds -->
+  <PropertyGroup Condition="'$(FSharpSourceBuild)' == 'true'">
+    <DeterministicSourcePaths>false</DeterministicSourcePaths>
+    <PublishWindowsPdb>false</PublishWindowsPdb>
+    <RepositoryUrl Condition="'$(RepositoryUrl)' == ''">https://github.com/Microsoft/visualfsharp</RepositoryUrl>
+    <RepositoryType Condition="'$(RepositoryType)' == ''">git</RepositoryType>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(FSharpSourceBuild)' == 'true' AND '$(RepositoryCommit)' == ''">
+    <_DotGitDir>$(RepoRoot).git</_DotGitDir>
+    <_HeadFileContent Condition="Exists('$(_DotGitDir)/HEAD')">$([System.IO.File]::ReadAllText('$(_DotGitDir)/HEAD').Trim())</_HeadFileContent>
+    <_RefPath Condition="$(_HeadFileContent.StartsWith('ref: '))">$(_DotGitDir)/$(_HeadFileContent.Substring(5))</_RefPath>
+    <RepositoryCommit>$(BUILD_SOURCEVERSION)</RepositoryCommit>
+    <RepositoryCommit Condition="'$(RepositoryCommit)' == '' AND '$(_RefPath)' != '' and Exists('$(_RefPath)')">$([System.IO.File]::ReadAllText('$(_RefPath)').Trim())</RepositoryCommit>
+  </PropertyGroup>
+
   <!-- other -->
   <PropertyGroup>
     <NoWarn Condition="'$(Language)' == 'F#'">$(NoWarn);FS2003</NoWarn><!-- warning when AssemblyInformationalVersion looks like '1.2.3-dev' -->

FSharp.Profiles.props

@@ -4,16 +4,6 @@
   <Import Project="eng\targets\NGenBinaries.targets" />
   <Import Project="FSharp.Profiles.props" />
 
-  <PropertyGroup Condition="'$(UseAssetTargetFallback)' == 'true'">
-    <!--
-    HACK: Necessary because the `netstandard1.6` version of FSharp.Compiler.Private requires a package that isn't
-    necessary for `net46`, but the package has a requirement on `net462`.  The reference is excluded from the build
-    during `net46`, but for purposes of restore needs to be present.
-    -->
-    <AssetTargetFallback>$(AssetTargetFallback);net462</AssetTargetFallback>
-    <NoWarn>$(NoWarn);NU1605;NU1701</NoWarn>
-  </PropertyGroup>
-
   <PropertyGroup>
     <CompileDependsOn>$(CompileDependsOn);CopyAndSubstituteTextFiles</CompileDependsOn>
   </PropertyGroup>

FSharpBuild.Directory.Build.props

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <configuration>
   <solution>
     <add key="disableSourceControlIntegration" value="true" />

FSharpBuild.Directory.Build.targets

@@ -15,11 +15,13 @@ This repo exists as a downstream packaging repository for the [FSharp.Compiler.S
 * Hosting [public documentation](http://fsharp.github.io/FSharp.Compiler.Service/)
 * Serving as a stable base for Fable
 
-
 It is a fork of the official F# source repository, which is located at [microsoft/visualfsharp](https://github.com/microsoft/visualfsharp). **All** issues and contributions should be raised there. All feature development should be targeted there. Once contributions are accepted into [microsoft/visualfsharp](https://github.com/microsoft/visualfsharp), they will be integrated into this repository for packaging and release.
 
 If you need to add customizations to FSharp.Compiler.Service for your own uses, you should clone [microsoft/visualfsharp](https://github.com/microsoft/visualfsharp) and build the FSharp.Compiler.Service binaries from there. The process is exactly the same as it is described below.
 
+### No contribution is too small
+
+Even if you find a single-character typo, we're happy to take the change! Although the codebase can feel daunting for beginners, we and other contributors are happy to help you along.
 
 ## Documentation
 
@@ -73,4 +75,4 @@ The maintainers of this repository are:
  - [Tomas Petricek](http://github.com/tpetricek)
  - [Enrico Sada](http://github.com/enricosada)
  - [Chet Husk](http://github.com/baronfel)
- - Many people have helped including [Robin Neatherway](https://github.com/rneatherway), [Dave Thomas](http://github.com/7sharp9), [Lincoln Atkinson](http://github.com/latkin), [Kevin Ransom](http://github.com/KevinRansom), [Vladimir Matveev](http://github.com/vladima) and others
+ - Many people have helped including [Robin Neatherway](https://github.com/rneatherway), [Dave Thomas](http://github.com/7sharp9), [Lincoln Atkinson](http://github.com/latkin), [Kevin Ransom](http://github.com/KevinRansom), [Vladimir Matveev](http://github.com/vladima) and others