Skip to content

Commit af8e5aa

Browse files
committed
Make async_name_to_address_middleware a default middleware
1 parent 3d8cd36 commit af8e5aa

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

tests/core/manager/test_default_middlewares.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
async_attrdict_middleware,
77
async_buffered_gas_estimate_middleware,
88
async_gas_price_strategy_middleware,
9+
async_name_to_address_middleware,
910
async_validation_middleware,
1011
attrdict_middleware,
1112
buffered_gas_estimate_middleware,
@@ -15,7 +16,7 @@
1516
)
1617

1718

18-
def test_default_sync_middlwares(w3):
19+
def test_default_sync_middlewares(w3):
1920
expected_middlewares = [
2021
(gas_price_strategy_middleware, "gas_price_strategy"),
2122
(name_to_address_middleware(w3), "name_to_address"),
@@ -32,9 +33,10 @@ def test_default_sync_middlwares(w3):
3233
assert default_middlewares[x][1] == expected_middlewares[x][1]
3334

3435

35-
def test_default_async_middlwares():
36+
def test_default_async_middlewares():
3637
expected_middlewares = [
3738
(async_gas_price_strategy_middleware, "gas_price_strategy"),
39+
(async_name_to_address_middleware, "name_to_address"),
3840
(async_attrdict_middleware, "attrdict"),
3941
(async_validation_middleware, "validation"),
4042
(async_buffered_gas_estimate_middleware, "gas_estimate"),

web3/manager.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
async_attrdict_middleware,
3131
async_buffered_gas_estimate_middleware,
3232
async_gas_price_strategy_middleware,
33+
async_name_to_address_middleware,
3334
async_validation_middleware,
3435
attrdict_middleware,
3536
buffered_gas_estimate_middleware,
@@ -139,7 +140,7 @@ def default_middlewares(w3: "Web3") -> List[Tuple[Middleware, str]]:
139140
"""
140141
return [
141142
(gas_price_strategy_middleware, "gas_price_strategy"),
142-
(name_to_address_middleware(w3), "name_to_address"), # Add Async
143+
(name_to_address_middleware(w3), "name_to_address"),
143144
(attrdict_middleware, "attrdict"),
144145
(validation_middleware, "validation"),
145146
(abi_middleware, "abi"),
@@ -154,6 +155,7 @@ def async_default_middlewares() -> List[Tuple[AsyncMiddleware, str]]:
154155
"""
155156
return [
156157
(async_gas_price_strategy_middleware, "gas_price_strategy"),
158+
(async_name_to_address_middleware, "name_to_address"),
157159
(async_attrdict_middleware, "attrdict"),
158160
(async_validation_middleware, "validation"),
159161
(async_buffered_gas_estimate_middleware, "gas_estimate"),

0 commit comments

Comments
 (0)