Skip to content

Add TS lint testing and @typescript-eslint/explicit-module-boundary-types warning #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

FSVetaz
Copy link
Contributor

@FSVetaz FSVetaz commented Mar 26, 2025

We want to use @typescript-eslint/explicit-module-boundary-types and will have it as a warning for now to not disrupt us as much. Later on we will make it an error.
This is the first TS rule we are adding in this configuration, therefore, the ts eslint config and a ts file for testing local eslint issues are now part of testing.

Helps resolve https://icseng.atlassian.net/browse/TREEWEB-8084

To-Dos

  • Run tests (part of pre-push hook)
  • Update demo and tests, if linting configuration is being changed
  • Update documentation & README
  • Increment package.json version

@FSVetaz FSVetaz marked this pull request as ready for review March 26, 2025 21:14
@FSVetaz FSVetaz requested a review from a team as a code owner March 26, 2025 21:14
Copy link
Collaborator

@skye2k2 skye2k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Glad to add gradual support to keep pushing our code to be better.

@skye2k2 skye2k2 merged commit 9f6b2b7 into master Mar 27, 2025
1 check passed
@skye2k2 skye2k2 deleted the jordi/ts-lint branch March 27, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants