Skip to content

ieeeck: use ieee_arithmetic intrinsics #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

ieeeck: use ieee_arithmetic intrinsics #933

merged 1 commit into from
Feb 10, 2025

Conversation

perazz
Copy link
Member

@perazz perazz commented Feb 7, 2025

Instead of old-style, possibly inf/nan trapping checks, use the Modern Fortran ieee_arithmetic module.

Fix #932

cc: @loiseaujc @jalvesz @jvdp1

jalvesz
jalvesz approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@jalvesz jalvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @perazz! much cleaner this way!!

jvdp1
jvdp1 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @perazz . Clean code!

@perazz
Copy link
Member Author

perazz commented Feb 10, 2025

Thank you @jvdp1 @jalvesz: with two approvals, I will merge this one.

@perazz perazz merged commit 15462e9 into fortran-lang:master Feb 10, 2025
14 checks passed
@perazz perazz deleted the standardize_ieeeck branch February 10, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdp1 jvdp1 jvdp1 approved these changes

@jalvesz jalvesz jalvesz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Floating point exception encountered in svdvals(A) originating from a call to stdlib_ieeeck
3 participants
@perazz @jvdp1 @jalvesz