-
Notifications
You must be signed in to change notification settings - Fork 188
[stdlib_linalg] matrix property checks #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
3d86036
Add all single input chekcs
ghbrown 6d9848f
Fix is_diagonal and add some tests
ghbrown 4c5fdf1
Add is_symmetric and is_skew_symmetric tests
ghbrown f28bb47
Add tests for is_skew_symmetric and start is_triangular tests
ghbrown 857a9bb
Start complex is_triangular tests
ghbrown a14af3b
Add final tests
ghbrown bdae9ae
Style changes
ghbrown e1f07e6
Separate calls to check in tests
ghbrown 55e0dd0
Extend is_hamiltonian to real types and add is_hamiltonian tests
ghbrown fd8fcf1
Replace A_shape with size() calls
ghbrown 3196fea
Add docs and examples
ghbrown c31200f
Add stdlib_error dependency to stdlib_linalg for GNU make
ghbrown ce2722d
Add missing slash to broken GNU makefile
ghbrown 0da0d7d
Change (.not * .eq *) to (* .ne. *) for brevity
ghbrown 1a9ddb3
Switch to modern relational operators
ghbrown ed42211
Change style of output comments in docs
ghbrown 58346ff
Remove doubled check for squareness
ghbrown a759929
Make zero variables into parameters
ghbrown 1915bbb
Clarify return value documentation
ghbrown 677c577
Change to more specific documentation URLs
ghbrown 080b552
update links for FORD
jvdp1 9412890
Merge pull request #1 from jvdp1/linalg_link
ghbrown 6f6f5ac
Separate out matrix property checks tests
ghbrown c3d07a1
Merge branch 'matrix_property_checks' of github.com:ghbrown/stdlib in…
ghbrown 8324fa7
Merge branch 'master' into matrix_property_checks
ghbrown 12be97b
Add back optval dependencies accidentally removed in merge conflict r…
ghbrown d0a4a76
Remove redundant tests after separation
ghbrown 0a0137b
After catch up merge
ghbrown 74abe0f
Add fypp version of is_square
ghbrown ecc38d1
Settle on global style for fypp templating and add is_diagonal and is…
ghbrown 009e22c
Implement all tests with testdrive and fypp
ghbrown 03306f1
Add missing source file to manual makefile
ghbrown 58fc9a2
Add missing separator for line break
ghbrown 09e333f
Correct error in fypp templating
ghbrown c7c8bcd
Fix GNU makefiles and cleanup cmake and fypp fixes
ghbrown 8d36da6
Blank line insertion and deletion
ghbrown 60f0fa6
Remove hash files generated during testing
ghbrown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be wise to move the implementations of all these functions fo submodules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had considered that, but it seemed like it would further pollute the already cluttered
src
directory.As long as this is fine with people, I can move them into their own submodules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have time to find the thread, but if I recall correctly our plan was that once a module (say
linalg
) reaches a certain size, we would introduce a new folder likelinalg/
in thesrc/
directory. We haven't done it yet for thestats
routines which would be another candidate. @jvdp1, what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A separate folder is actually what I wanted to ask for, but didn't know the overall plan or want to complicate things.
I am very much on board with having separate folders for modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall this discussion/thread (but it doesn't mean I didn't read it or didn't participate to it ;) ). However, I think it would be a good idea of having separate folders for modules/a set of modules related to the same topic.
For now, I would suggest to keep it as it is, or to only create submodules. We can discuss in an issue how to create folders, and if it is appropriate (also by keeping in mind that it must be compatible with fpm).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one issue to keep in mind with FORD when using subdirectories for the Fortran files, because only the basename will be visible in the documentation, like here: https://toml-f.github.io/toml-f/lists/files.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back, it was a single comment from Zaak Beekman in #7 (comment):
I agree we postpone the folder changes for a new PR, which will be linked with a newly created issue.