Skip to content

Logger2 - Changes mostly to make output thread and Asynchronous iO safe #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 59 commits into from
Closed

Logger2 - Changes mostly to make output thread and Asynchronous iO safe #244

wants to merge 59 commits into from

Conversation

wclodius2
Copy link
Contributor

Changed three files:

  • /src/stdlib_logger.f90
    • Fixed typos: Rrea_only_error to read_only_error, shortened lines to under 80 columns
    • Made output thread and asynchronous IO safe by making it a single string formatted using the new_line function
  • /doc/specs/stdlib_logger.md documented the changes in API in stdlib_logger.f90
  • /doc/specs/index.md included the logger in the index.

wclodius2 and others added 30 commits September 29, 2020 17:05
@wclodius2
Added core files for stdlib_bitsets
cd7e19d 
Added stdlib_bitsets.f90, stdlib_bitset_64.f90, and stdlib_bitset_large.f90 and modified CMakeLists.txt and Makefile.manual so they should compile the files.

[ticket: X]
@wclodius2
Prepared for testing of stdlib_bitsets
e35ebc7 
Added tests/bitsets/test_stdlib_bitset*.f90, tests/bitsets/CMakeLists.txt,
and tests/bitsets/Makefile.manual and modified tests/CMakeLists.txt and
tests/Makefile.manual to compile the test programs.

[ticket: X]
@wclodius2
Eliminated unused variablese
e2f3d66 
Eliminated unused variables in stdlib_bitset_64.f90, stdlib_bitset_large.f90
and rename variables called ablock to block_ in stdlib_bitset_large.f90

[ticket: X]
@wclodius2
Added documentation for stdlib_bitsets
7d778cd 
Added stdlib/doc/specs/stdlib_bitsets.md

[ticket: X]
@jvdp1
Update doc/specs/stdlib_bitsets.md
acfa3ac
@jvdp1
Update doc/specs/stdlib_bitsets.md
7c5361c
@jvdp1
formatting
eb2e5c1
@jvdp1
Update src/tests/Makefile.manual
e70c909
@jvdp1
Update doc/specs/stdlib_bitsets.md
8e25812
@wclodius2
Changed makefiles to accept stdlib_bitset*.fypp instead of stdlib_bit…
c9e851b 
…set*.f90

Changed makeefiles to preprocess ths stdlib_bitset*.fypp files to stdlib_bitset*.f90 files.

[ticket: X]
@wclodius2
Renamed files stdlib_bitset*.f90 to stdlib_bitset*.fypp
d80e5d9 
Renamed files stdlib_bitset*.f90 to fypp preprocessor stdlib_bitset*.fypp files

[ticket: X]
@wclodius2
Changed preprocessor files to generate logical assignments.
f2d67fc 
Changed stdlib_bitsets.fypp, stdlib_bitset_64.fypp, and stdlib_bitset_large.fypp
to generate the assignment procedures of logical arrays to and from bitsets.

[ticket: X]
@wclodius2
Removed files now generated by the preprocessor
2833ffa 
Removed stdlib_bitsets.f90, stdlib_bitset_64.f90, and stdlib_bitset_large.f90 as
they are now generated by the preprocessor.

[ticket: X]
@wclodius2
Modified code to use error_handler.
3844561 
Defined an error_handler subroutine in stdlib_bitsets.fypp and used it to handle
errors in stdlib_bitset_64.fypp and stdlib_bitset_large.fypp. Also was more
consistent in documenting status argument results. Added
char_string_too_large_error to status results.

[ticket: X]
@wclodius2
Better documented status results
9e9c252 
Was more consistent in using bulleted lists in documenting status error codes.
Added char_string_too_large_error to the error codes.

[ticket: X]
@wclodius2
Removed trailing blanks
421c4d2 
Working with fypp made it easier to add unwanted trailing blanks. I removed them.

[ticket: X]
@wclodius2
Added missing return
d2be3dc 
In all my editing I dropped a return in stdlib_bitset_64.fypp and failed
to run test_stdlib_bitset_64.

[ticket: X]
@wclodius2
Changed WRiTE to WRITE
b0c0f63 
Fixed typo in four places

[ticket: X]
@wclodius2
Changed the kind of bit
b12e398 
Changed the kind of bit from bits_kind to int64 to silence a spurious warning.

[ticket: X]
@wclodius2
Changed subtraction of bit from outside an int converson to inside
983a083 
Changing bit's kind to int64 and not putting it in the int conversion made the
arguments to clear and set of kind int64, for wwhich there was no specific
interface.

[ticket: X]
@wclodius2
Deleted redundant returns.
38095c0 
Deleted two returns at the end of procedures.

[ticket: X]
@wclodius2
Deleted redundant return
cc477b9 
Deleted return at the end of a procedure.

[ticket: X]
@wclodius2
Regularized code fences
beca325 
Unindented ```fortran and added trailing ``` to the example codes in the FORD comments,

[ticket: X]
@jvdp1
Some typs and obvious changes
d391970
@jvdp1
Apply suggestions from code review
84d7d33
@wclodius2
Corrected stdlib_bitsets.md
d6dc6b1 
Implemented most of the suggestions of Jeremie Vandenplas:
1. Rephrased the first paragraph adding a definition of bits and changed
'a sequence' to 'as a seqauence' and 'a subset' to 'as a subset'
2. Changed 'constants all integers' to 'integer constants'
3. Changed 'up 64 bits' to 'up to 64 bits'
4. Changed i'th to i-th
5. Made the summary of operations into a bulleted list
6. Moved the discussion of assignments to later in the text
7. Merged discussions of result character and result value for functions/operators
8. Remove `if ( bits(set0) /= 33)...`
9. Added commas
10. Changed `Result = ...` to `result = ...`
11. Changed state type of the result for the value function from logical to integer

[ticket: X]
@jvdp1
Update doc/specs/stdlib_bitsets.md
daa83d2
@jvdp1
Apply suggestions from code review
30c2116
@wclodius2
Merge branch 'bitsets3' of https://github.com/wclodius2/stdlib into b…
0e3b788 
…itsets3
@wclodius2
Changed file names
adab166 
Changed stdlib_bitset_64.fypp and stdlib_bitset_large.fypp to
stdlib_bitsets_64.fypp and stdlib_bitsets_large.fypp.

[ticket: X]
wclodius2 and others added 26 commits October 15, 2020 14:46
@wclodius2
Fixed typo in Makefile.manual
24881a5 
Changed stdlib_bitsest_64.fypp to stdlib_bitsets_64.fypp in Makefile.manual.

[ticket: X]
@jvdp1
typos
0554f5d
@wclodius2
Typos and bits_kind fixes
ecd6c82 
Fixed various typos found in stdlib_bitsets.fypp by Jeremie. Modified
stdlib_bitsets_large.fypp so it whould work for bits_kind==int64.

[ticket: X]
@wclodius2
Fixed digit_count
47c7d6e 
For digit_count in stdlib_bitsets_large.fypp replaced the select case construct
with a do loop and a divide by ten.

[ticket: X]
@wclodius2
Added dependence on stdlib_kinds.f90
80af2c5 
Added dependence of stdlib_bitsets.f90 on stdlib_kinds.f90.

[ticket: X]
@wclodius2
Fixed bits_kind breakage
0deab15 
Made constants in max et al bits_kind to match variables kind, fixed digit_count
in stdlib_bitsets_64.fypp.

[ticket: X]
@wclodius2
Fixed up constants
9f0e4a9 
 Made many constants of kind bits_kind so the pertinent procedures would be
 recognized.

[ticket: X]
@jvdp1
some typos
9f690fd
@wclodius2
Added discussion of undefined behavior
f705346 
Added discussion of the undefined behavior that can occur when the bitset
"sizes" for the two bitset arguments to "binary" procedures do not agree.

[ticket: X]
@wclodius2
Fixed typo
242950b 
Changed procedure to its plural procedures.

[ticket: X]
@wclodius2
Added reference to the bitsets module
032c440 
Addedl line refering to the fitsets source file.

[ticket: X]
@wclodius2
Made it easier to change bits_kind
e957342 
Introduced the parameters max_digits and overflow_bits to be used in checking
for overflows on reads and writes. The parameters need to be changed if
bits_kind is changed, and preferred parameters for bits_kind==int64 are
defined, but commented out.

[ticket: X]
@wclodius2
Replaced go to 100 with exit
9161fc7 
Replaced go to 100 with exit in both stdlib_bitsets_64.fypp and
stdlib_bitsets_large.fypp.

[ticket: X]
@wclodius2
Changed used modues
3235ab4 
Replaced the use of iso_fortran_env with stdlib_kinds.

[ticket: X]
@wclodius2
Changed handling of potential integer overflows on reads
523dbc6 
Changed handling of potential integer overflows on reads for bits_kind==int64,
changing max_digits from 20 to 19. Removed comment that my treatment may not be
quite right. Also fixed a typo in an error message.

[ticket: X]
@wclodius2
Numerous changes suggested by Jeremie
20a15e5 
Jeremie suggested numerous changes. I implemented most of them.

[ticket: X]
@wclodius2
Replaced go tos
57faccd 
At the suggestion of Jeremie I replaced a number of go tos.

[ticket: X]
@wclodius2
Replaced go tos
9c03d16 
Kreplaced go tos at the suggestion of Jeremie.

[ticket: X]
@wclodius2
Documented the "named" form for the comparison operations
5c2779d 
Documented the use of the "named" forms, .EQ., .NE., .GT., .GE., .LT., .LE., as
alternatives to the symbolic forms, ==, /=, >, >=, <, <= of the comparison
operations.

[ticket: X]
@milancurcic
typography fixes
99fa382
@milancurcic
add example to the first paragraph
acb7cdb
@wclodius2
Merge https://github.com/fortran-lang/stdlib into bitsets3
1be7ca3
@wclodius2
Fixed typos and line lengths
ef245fa 
Change `Rrea_only_error` to `read_only_error` and changed some lines that were
longer than 80 columns wide to be shorter.

[ticket: X]
@wclodius2
Added logger to the index
354fb54 
Added stdlib_logger.html to ./doc/specs/index.md

[ticket: X]
@wclodius2
Fixed formatting of output
674f2cd 
Added a blank after a comma to the output of one line.

[ticket: X]
@wclodius2
Made the code thread/asynchronous IO safe
00862ff 
Changed the code so the main output is a single character string with formatting
from insertions of new_line so the output cannot be broken up by other writes to
the same file.

[ticket: X]
@jvdp1
Copy link
Member

jvdp1 commented Nov 16, 2020

Thanks @wclodius2 for this PR. It seems that the branch logger2 is on top of bitset3, which makes things difficult to review. Would it be possible to rebase logger2 on master? @certik @milancurcic any tips on how to this?

@milancurcic
Copy link
Member

Assuming upstream is https://github.com/fortran-lang/stdlib and origin is [email protected]:wclodius2/stdlib (if using SSH keys auth) or https://github.com/wclodius2/stdlib (if using password auth), then in William's local git repo, I think this is the procedure:

git checkout master # go to master branch in the local repo
git fetch upstream # fetch updates from the remote repo (fortran-lang/stdlib)
git merge upstream/master # merge updates into local master
git checkout -b logger-safe-async-io # create and switch to the new branch
# make changes to the files
git add <changed-file> && git commit -m "commit message" # for each meaningful unit of change
git push origin logger-safe-async-io

@milancurcic
Copy link
Member

Closing in favor of #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wclodius2 @jvdp1 @milancurcic