Skip to content

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

allow # in fullNames for components

What issues does this PR fix or reference?

#, @@
@W-5185915@

Functionality Before

For a component with # in its name (see example on the WI), SDR would call string.split('#') and get confused. When trying to pull, it wouldn't be able to find matching metadata

Functionality After

finds metadata (has to split into two strings on the first instance of the delimiter)

@mshanemc mshanemc requested review from a team as code owners October 11, 2021 22:07
Copy link
Member

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hope there's never a metadata type with # in it

@mshanemc
Copy link
Contributor Author

let's hope there's never a metadata type with # in it

Custom#Labels

@WillieRuemmele
Copy link
Member

QA'd and it's possible to have # in metadata names, but it is also possible to have too many # in metadata names, and after encoding from # to %23 will blow past Node's limit for file names causing an ENAMETOOLONG error

@WillieRuemmele WillieRuemmele merged commit 79aec1f into main Oct 28, 2021
@WillieRuemmele WillieRuemmele deleted the sm/pound-sign-in-component-names branch October 28, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants