Skip to content

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented May 30, 2025

What does this PR do?

When retrieving a CustomObject that has an empty object-meta.xml file, include the CustomObject in the manifest entry and not just custom fields or other children. This does not affect deploying or converting since different behavior is required for those operation. I.e., including a CustomObject in the manifest without the object-meta data would fail deployment validation. See #1375

What issues does this PR fix or reference?

#3300, @W-18650723@

Functionality Before

sf project retrieve start -m CustomObject:TestObject__c with an empty object-meta.xml file would result in a manifest like this:

<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>TestObject__c.TestField__c</members>
        <name>CustomField</name>
    </types>
    <version>63.0</version>
</Package>

Functionality After

<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>TestObject__c.TestField__c</members>
        <name>CustomField</name>
    </types>
    <types>
        <members>TestObject__c</members>
        <name>CustomObject</name>
    </types>
    <version>63.0</version>
</Package>

@shetzel shetzel requested a review from a team as a code owner May 30, 2025 21:09
@soridalac
Copy link
Contributor

QA notes:
✅ : Run sf project retrieve start -m CustomObject:TestObject__c with an empty object-meta.xml file. Result with correct content of the object-meta.xml file.

@soridalac soridalac merged commit db8cb3e into main Jun 2, 2025
49 checks passed
@soridalac soridalac deleted the sh/retrieve-with-parent branch June 2, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants