Skip to content
This repository was archived by the owner on Feb 10, 2019. It is now read-only.

Updated graphiql view template with latest version from master branch #218

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

4levels
Copy link

@4levels 4levels commented Oct 6, 2017

Copied the graphiql.php view file from master

@coveralls
Copy link

coveralls commented Oct 6, 2017

Coverage Status

Coverage remained the same at 71.549% when pulling 8ea1d49 on 4levels:feature/relay into 11ef6fb on Folkloreatelier:feature/relay.

@dmongeau
Copy link
Member

dmongeau commented Oct 6, 2017

Thanks for this.
One thing, I was using superagent because fetch doesn't seems to be compatible with laravel-debugbar and I found it useful to be able to inspect everything when doing query in graphiql. Maybe laravel-debugbar updated to catch fetch requests, we will need to check

@4levels
Copy link
Author

4levels commented Oct 6, 2017

Hi,

this wast just a minimal effort of my side (copy paste from master).
I never saw the Graphiql interface play nice with errors, I always have to use the dev-tools to view the actual errors. I didn't notice a change here after I updated the file, but I might be not looking in the right place.

I struggled a lot to get Relay Mutations working with Lumen and in the process I ended up using the latest versions as seen in the master branch.

Just my 2 cents ;-)

Kind regards,

Erik

@dmongeau dmongeau merged commit c80b697 into folkloreinc:feature/relay Oct 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants